perf(cache): use redis unlink for key deletion - #10658
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thanks for your contribution @muhlemmer! 🎉Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10658 +/- ##
==========================================
+ Coverage 64.47% 64.49% +0.01%
==========================================
Files 1793 1793
Lines 163392 163392
==========================================
+ Hits 105352 105373 +21
+ Misses 52866 52851 -15
+ Partials 5174 5168 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adlerhurst
approved these changes
Sep 6, 2025
muhlemmer
enabled auto-merge (squash)
September 8, 2025 07:59
livio-a
pushed a commit
that referenced
this pull request
Sep 8, 2025
# Which Problems Are Solved The usage of the Redis `DEL` command showed blocking and slowdowns during load-tests. # How the Problems Are Solved Use [`UNLINK`](https://redis.io/docs/latest/commands/UNLINK/) instead. # Additional Changes - none # Additional Context - closes #8930 (cherry picked from commit a06ae2c)
livio-a
pushed a commit
that referenced
this pull request
Sep 15, 2025
# Which Problems Are Solved The usage of the Redis `DEL` command showed blocking and slowdowns during load-tests. # How the Problems Are Solved Use [`UNLINK`](https://redis.io/docs/latest/commands/UNLINK/) instead. # Additional Changes - none # Additional Context - closes #8930 (cherry picked from commit a06ae2c)
Draft
fo-ofc
pushed a commit
to O-F-C/zitadel
that referenced
this pull request
Jun 10, 2026
# Which Problems Are Solved The usage of the Redis `DEL` command showed blocking and slowdowns during load-tests. # How the Problems Are Solved Use [`UNLINK`](https://redis.io/docs/latest/commands/UNLINK/) instead. # Additional Changes - none # Additional Context - closes zitadel#8930
fo-ofc
pushed a commit
to O-F-C/zitadel
that referenced
this pull request
Jun 10, 2026
# Which Problems Are Solved The usage of the Redis `DEL` command showed blocking and slowdowns during load-tests. # How the Problems Are Solved Use [`UNLINK`](https://redis.io/docs/latest/commands/UNLINK/) instead. # Additional Changes - none # Additional Context - closes zitadel#8930 (cherry picked from commit 981afa3)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Problems Are Solved
The usage of the Redis
DELcommand showed blocking and slowdowns during load-tests.How the Problems Are Solved
Use
UNLINKinstead.Additional Changes
Additional Context