Repository navigation
Fix build: update secp256k1 hash and CI Zig version - #46
Merged
Merged
Conversation
- Update zig-eth-secp256k1 hash to match current upstream - Update CI from Zig 0.14.1 to 0.15.0 to match minimum_zig_version in build.zig.zon Fixes zigstack#45
Collaborator
|
Hey @koko1123 Thanks for the submission. I have however, upgraded to zig 0.15.2 and hence closing this PR. There are other issues which you can pickup if you are still interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two related build issues:
Stale dependency hash: The
zig-eth-secp256k1dependency hash inbuild.zig.zonno longer matches the upstreammainbranch tarball. Updated to the current hash.CI Zig version mismatch: CI was using Zig 0.14.1, but
build.zig.zondeclaresminimum_zig_version = "0.15.0". Updated all CI jobs to use Zig 0.15.0.Test plan
zig build test -Doptimize=ReleaseSafepasses locally (macOS ARM64)Fixes #45