Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1870 +/- ##
==========================================
+ Coverage 99.48% 99.50% +0.01%
==========================================
Files 59 59
Lines 12280 12494 +214
==========================================
+ Hits 12217 12432 +215
+ Misses 63 62 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
Cluster.respond_to_commandandCluster.on_command, providing dedicated APIs for both replying to and reacting to commands. The dual API is a little strange but the purpose of having both is to allow zigpy to internally userespond_to_commandfor a ZCL default response implementation that is overridden by concrete subclasses.The purpose of this change is to fix a bug flagged in zigpy/ziggurat#56: zigpy currently responds to poll control checkins with an extra default response due to our lack of a proper API to do this.