Repository navigation
TST: ignore shape-mutation deprecation warnings from numpy 2.5 on yt 4.4.x - #5518
Conversation
neutrinoceros
added
blocker
|
remaining failures are unrelated:
|
chrishavlin
left a comment
chrishavlin
left a comment
There was a problem hiding this comment.
re: the failing image tests, I agree they're unrelated, good to merge thisone.
presumably because of a change in matplotlib 3.11 we haven't taken into account on the main branch yet
of the 10 or so that I looked at, all the failed image diffs show a slight shift of all the axis labels, e.g. the diff for yt.visualization.tests.test_image_comp_2D_plots.TestPhasePlot.test_phaseplot_xax2-yax2-zax2-1-fractional_accumulation :
didn't notice anything obvious in the 3.11.1 or 3.11.0 release notes that might be the culprit -- there were a bunch of font/text related updates, but they all looked like new features to me.
|
I've seen the same change affect astropy's image tests a couple months back. Here are the references |
PR Summary
For reference, these warnings are already correctly handled on the dev branch (#5309), but the patch isn't strictly backwards compatible so we chose not to backport it. As a result, ignoring the warning is necessary to fix CI on the backport branch.
PR Checklist