feat: show highlighted absolute output path on completion - #1378

The PR changes reportSummary() to print absolute paths for both single and multi-part output, but the existing cliReport unit tests don't assert the Output: line at all. Adding assertions for the absolute-path output (including the multi-part first … last (N parts) case) would help prevent regressions and ensure the new UX is covered.

⚠️ Potential issue | 🟠 Major

Keep the --skill output location consistent across summary and completion.

Line 97 still renders options.skillDir through getDisplayPath(), while Lines 62-65 ignore options.skillDir and pass the regular file path into reportCompletion(). In skill mode the summary can stay relative and the new completion banner can point at a different target entirely.

   reportSummary(cwd, packResult, config, options);
   logger.log('');

   const outputPath =
-    packResult.outputFiles && packResult.outputFiles.length > 0
-      ? path.resolve(cwd, packResult.outputFiles[0])
-      : path.resolve(cwd, config.output.filePath);
+    config.skillGenerate !== undefined && options.skillDir
+      ? path.resolve(cwd, options.skillDir)
+      : packResult.outputFiles && packResult.outputFiles.length > 0
+        ? path.resolve(cwd, packResult.outputFiles[0])
+        : path.resolve(cwd, config.output.filePath);

   reportCompletion(outputPath);
@@
   if (config.skillGenerate !== undefined && options.skillDir) {
-    const displayPath = getDisplayPath(options.skillDir, cwd);
-    logger.log(`       Output: ${displayPath} ${pc.dim('(skill directory)')}`);
+    const skillDirPath = path.resolve(cwd, options.skillDir);
+    logger.log(`       Output: ${skillDirPath} ${pc.dim('(skill directory)')}`);
   } else {
@@
-  logger.log(`📁 Output file generated at:`);
+  logger.log('📁 Output generated at:');

Also applies to: 95-111, 244-250

Verify each finding against the current code and only fix it if needed.

In `@src/cli/cliReport.ts` around lines 59 - 67, The completion banner uses a raw
file path while the summary uses getDisplayPath(options.skillDir...), causing
inconsistent output in skill mode; update the outputPath computation in the
reportCompletion call to pass the same display path used by reportSummary (use
getDisplayPath(options.skillDir, path.resolve(cwd, ...)) or, if options.skillDir
is falsy, fall back to the resolved path) so reportCompletion receives the
identical display string; also apply the same change to the other similar blocks
that compute outputPath (the other reportSummary/reportCompletion pairs).

The logic for determining the output path is duplicated here and in reportSummary. Additionally, this implementation only considers the first file when multiple output files are generated (split output), which makes the completion message singular and potentially misleading.

The range display (e.g., path … path (1 parts)) is used even when only a single output file is generated. It would be cleaner to show a single path in that case.

        packResult.outputFiles.length === 1
          ? `       Output: ${firstAbsPath}`
          : `       Output: ${firstAbsPath} ${pc.dim('…')} ${lastAbsPath} ${pc.dim(`(${packResult.outputFiles.length} parts)`)}`,

The label "Output file generated at:" is singular. If the user has configured split output, multiple files are generated. Consider a more neutral label like "Output generated at:" or pluralizing based on the input.

🟡 Test expects wrong heading string — missing the word "file"

The test asserts '📁 Output generated at:' but getOutputSummary at src/cli/cliReport.ts:265 returns '📁 Output file generated at:' (note the extra word "file"). This test will fail at runtime because the strings don't match.

Was this helpful? React with 👍 or 👎 to provide feedback.

🟡 resolveOutputPath only returns first file, making multi-file completion banner unreachable

resolveOutputPath returns string and only returns the first output file (packResult.outputFiles[0]) at src/cli/cliReport.ts:35. reportCompletion at line 285 accepts string | string[] and getOutputSummary (lines 270-282) has multi-file logic for shared directories. However, since resolveOutputPath always produces a single string, the multi-file branches in getOutputSummary are dead code. When split output generates multiple files, the completion banner misleadingly shows only the first file instead of all output files or their shared directory.

The resolveOutputPath function returns a single string, but reportCompletion and getOutputSummary are designed to handle string | string[]. When packResult.outputFiles has multiple entries (split output), only the first file path is returned, making the multi-file display logic in getOutputSummary unreachable dead code.

To fix this, resolveOutputPath should return string | string[] and pass all output file paths through:
- Change the return type of resolveOutputPath to string | string[]
- When packResult.outputFiles has multiple entries, return all of them (mapped through path.resolve)
- When it has one entry, return the single resolved path
- The skill dir and fallback branches stay as single strings

Alternatively, if the intent is to always show a single path in the completion banner, then the multi-file branches in getOutputSummary should be removed as they are misleading dead code.

Was this helpful? React with 👍 or 👎 to provide feedback.