Skip to content

Unary/Binary/N mapper #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntoinePrv merged 27 commits into from
Sep 29, 2026
Merged

Unary/Binary/N mapper #8

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e48a932
Add map_unary
AntoinePrv Sep 10, 2026
e73d9e0
Add sqrt and abs
AntoinePrv Sep 10, 2026
678777e
Refactor data library
AntoinePrv Sep 10, 2026
bb86eee
Improve map_unary tail
AntoinePrv Sep 10, 2026
96f94d2
Improve map_unary header
AntoinePrv Sep 10, 2026
85db521
Add exp unary function
AntoinePrv Sep 10, 2026
01eb843
Add benchmarks
AntoinePrv Sep 10, 2026
b2fa5e3
Fixed element map_unary contract
AntoinePrv Sep 11, 2026
d9e97ca
Add upcast test and benchmark
AntoinePrv Sep 14, 2026
87f5e53
Fix defaults
AntoinePrv Sep 14, 2026
7658e8b
Rename test files
AntoinePrv Sep 14, 2026
68f2420
Remove i386
AntoinePrv Sep 14, 2026
3de529d
Add transform benchmarks
AntoinePrv Sep 14, 2026
ea0cbb6
Add arch in benchmark name
AntoinePrv Sep 14, 2026
9eefd0b
Fix benchmarks
AntoinePrv Sep 14, 2026
2afa6a5
Split benchmarks
AntoinePrv Sep 16, 2026
f25fea3
More explicit unary benchmarks
AntoinePrv Sep 16, 2026
656395f
Refactor map_unary with helpers
AntoinePrv Sep 16, 2026
6c65a1d
Generic map_chunk
AntoinePrv Sep 16, 2026
f6816a8
Refactor map_unrolled
AntoinePrv Sep 16, 2026
039fa1f
Refactor map_loop
AntoinePrv Sep 17, 2026
09030a1
Refactor map_n helper
AntoinePrv Sep 17, 2026
ee1498e
Rename map options
AntoinePrv Sep 17, 2026
022ea0d
Rename builder.hpp > map.hpp
AntoinePrv Sep 17, 2026
24c0c7d
Add binary benchmarks
AntoinePrv Sep 17, 2026
20784fc
Optimize small memcpy
AntoinePrv Sep 17, 2026
eadbce2
Fix CI
AntoinePrv Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix defaults
  • Loading branch information
@AntoinePrv
AntoinePrv committed Sep 14, 2026
commit 87f5e53819424fff12d028b8e76a89e6614569e4
4 changes: 2 additions & 2 deletions benchmark/bench_math.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ namespace
static_cast<std::int64_t>(state.iterations() * size * 2 * sizeof(input_t)));
}

template <typename Op, typename Alloc, alignment aligned = {}>
template <typename Op, typename Alloc, alignment aligned = alignment{}>
void bench_simd(benchmark::State& state)
{
bench_unary<Op, Alloc>(
Expand Down Expand Up @@ -78,7 +78,7 @@ namespace
using unaligned_alloc = typename xsimd::test::unaligned_vector<input_t>::allocator_type;

register_bench<Op>("scalar/aligned", bench_scalar<Op, aligned_alloc>);
register_bench<Op>("simd/aligned", bench_simd<Op, aligned_alloc, { .start_aligned = true }>);
register_bench<Op>("simd/aligned", bench_simd<Op, aligned_alloc, alignment { .start_aligned = true }>);
register_bench<Op>("simd/unaligned", bench_simd<Op, unaligned_alloc>);
}

Expand Down
4 changes: 2 additions & 2 deletions include/xsimd_algorithm/builder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ namespace xsimd::builder
/// std::array<batch<U, Arch>, batch_arity<U, T>>, both spanning the same element count.
/// When arity is one, a callback over plain batches is accepted as well.
template <
alignment align = {},
unary_options opts = {},
alignment align = alignment{},
unary_options opts = unary_options{},
typename Arch = xsimd::default_arch,
typename T, typename U, typename Func>
XSIMD_INLINE void map_unary(std::span<T const> in, std::span<U> out, Func&& func)
Expand Down
6 changes: 3 additions & 3 deletions include/xsimd_algorithm/math.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
namespace xsimd::algo
{
template <
xsimd::builder::alignment align = {},
xsimd::builder::alignment align = xsimd::builder::alignment{},
typename Arch = xsimd::default_arch,
typename T>
void sqrt(std::span<T const> in, std::span<T> out)
Expand All @@ -28,7 +28,7 @@ namespace xsimd::algo
}

template <
xsimd::builder::alignment align = {},
xsimd::builder::alignment align = xsimd::builder::alignment{},
typename Arch = xsimd::default_arch,
typename T>
void abs(std::span<T const> in, std::span<T> out)
Expand All @@ -40,7 +40,7 @@ namespace xsimd::algo
}

template <
xsimd::builder::alignment align = {},
xsimd::builder::alignment align = xsimd::builder::alignment{},
typename Arch = xsimd::default_arch,
typename T>
void exp(std::span<T const> in, std::span<T> out)
Expand Down
2 changes: 1 addition & 1 deletion test-utils/include/xsimd_test_utils/math_data.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace xsimd::test
}
}

template <xsimd::builder::alignment aligned = {}>
template <xsimd::builder::alignment aligned = xsimd::builder::alignment{}>
static void apply_range_simd(std::span<input_t const> in, std::span<output_t> out)
{
constexpr builder::unary_options opts = { .unroll_factor = 4, .pure = Derived::pure };
Expand Down
4 changes: 2 additions & 2 deletions test-utils/include/xsimd_test_utils/math_ops.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace xsimd::test

static constexpr auto name = "sqrt";

template <xsimd::builder::alignment aligned = {}>
template <xsimd::builder::alignment aligned = xsimd::builder::alignment{}>
static void apply(std::span<T const> in, std::span<T> out)
{
xsimd::algo::sqrt<aligned>(in, out);
Expand All @@ -53,7 +53,7 @@ namespace xsimd::test

static constexpr auto name = "abs";

template <xsimd::builder::alignment aligned = {}>
template <xsimd::builder::alignment aligned = xsimd::builder::alignment{}>
static void apply(std::span<T const> in, std::span<T> out)
{
xsimd::algo::abs<aligned>(in, out);
Expand Down
7 changes: 3 additions & 4 deletions test/test_math.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

namespace
{
template <typename Op, typename Alloc, xsimd::builder::alignment aligned = {}>
template <typename Op, typename Alloc, xsimd::builder::alignment aligned = xsimd::builder::alignment{}>
void check_unary_math()
{
// Not a multiple of the batch size, to exercise the tail.
Expand Down Expand Up @@ -50,16 +50,15 @@ TEST_CASE_TEMPLATE(
xsimd::test::abs_op<double>,
xsimd::test::exp_op<float>,
xsimd::test::exp_op<double>,
xsimd::test::widen_op<std::int32_t>
)
xsimd::test::widen_op<std::int32_t>)
{
using input_t = typename Op::input_t;
using aligned_allocator = typename xsimd::test::aligned_vector<input_t>::allocator_type;
using unaligned_allocator = typename xsimd::test::unaligned_vector<input_t>::allocator_type;

SUBCASE("aligned without header")
{
check_unary_math<Op, aligned_allocator, { .start_aligned = true }>();
check_unary_math<Op, aligned_allocator, xsimd::builder::alignment { .start_aligned = true }>();
}

SUBCASE("aligned with header")
Expand Down
Loading