Skip to content

Python: Add support for 3.10 - #3293

Merged
Akeboshiwind merged 5 commits into
xtdb:mainfrom
ake-forks:py_support-3.10
Apr 10, 2024
Merged

Python: Add support for 3.10#3293
Akeboshiwind merged 5 commits into
xtdb:mainfrom
ake-forks:py_support-3.10

Conversation

@Akeboshiwind

@Akeboshiwind Akeboshiwind commented Apr 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why? It's the version that google colab runs 🤷

Not tested anything other than:

from xtdb_juxt import Xtdb
from xtdb_juxt.tx import PutDocs
from xtdb_juxt.query import *

client = Xtdb(f"http://localhost:3000")

txs = [PutDocs("docs", {"xt$id": 1, "foo": "hello"}, {"xt$id": 2, "bar": "test"})]
client.submit_tx(txs)
client.query(From("docs", projectAllCols=True))

@Akeboshiwind
feat(python): reduce minimum supported version to 3.10
f9c1346 
This is the version that google colab runs
@Akeboshiwind
fix(python): type error
765c511 
This syntax was only supported in 3.11:
https://peps.python.org/pep-0646/
@Akeboshiwind
fix(python): type error
c3bc55d
@Akeboshiwind
fix(python): manually replace Z in system time
154a8f5 
Better parsing in datetime.fromisoformat was only added in 3.11:
python/cpython#80010

Another option is to add python-dateutil as a dependency, not tested
that though
@Akeboshiwind
fix(python): use python-dateutil instead of string hack
174c657
@Akeboshiwind
Akeboshiwind marked this pull request as ready for review April 10, 2024 10:11
@Akeboshiwind Akeboshiwind changed the title [WIP] Python: Add support for 3.10 Python: Add support for 3.10 Apr 10, 2024
@Akeboshiwind
Akeboshiwind merged commit bc361f1 into xtdb:main Apr 10, 2024
@Akeboshiwind
Akeboshiwind deleted the py_support-3.10 branch April 10, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Akeboshiwind