Fix typo in variable name nat_rule_name_shortned - #212

Purpose

Corrects a typo in the variable name nat_rule_name_shortned used in the Azure firewall modules.
Resolves #157

Goals

Ensure correct spelling (nat_rule_name_shortened) of the variable in variable definitions and its resource implementations.

Approach

Updated references to the variable nat_rule_name_shortned to nat_rule_name_shortened in the following files:

• modules/azurerm/Firewall-LB-DNAT-Rule-Collection/variables.tf
• modules/azurerm/Firewall-LB-DNAT-Rule-Collection/firewall_dnat_rules.tf
• modules/azurerm/Firewall-Multiple-PIP/variables.tf
• modules/azurerm/Firewall-Multiple-PIP/nat_rules.tf

Ran terraform fmt -recursive to ensure standard HCL formatting is preserved.

User stories

N/A

Release note

Corrected the typo in variable name nat_rule_name_shortned to nat_rule_name_shortened in azurerm Firewall modules.

Documentation

N/A - This is a bug fix for an internal variable naming typo.

Training

N/A

Certification

N/A - This change has no impact on certification exams.

Marketing

N/A

Automation tests

• Unit tests
  N/A
• Integration tests
  Validated configurations successfully via local terraform init and terraform validate on the affected modules.

Security checks

• Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
• Ran FindSecurityBugs plugin and verified report? N/A (Not a Java project)
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

Users of the Firewall-LB-DNAT-Rule-Collection and Firewall-Multiple-PIP modules who define the nat_rule_name_shortned attribute in their dynamic_nat_rules configuration block will need to update the key name to nat_rule_name_shortened when upgrading.

Test environment

• OS: macOS
• Terraform version: v1.15.5

Learning

N/A