Skip to content

fix: update spawn command to concatenate command and flags - #14158

Merged
ascorbic merged 2 commits into
withastro:mainfrom
bjohansebas:fix-warning
Jul 30, 2025
Merged

ascorbic merged 2 commits into
withastro:mainfrom
bjohansebas:fix-warning

Conversation

@bjohansebas

Copy link
Copy Markdown
Contributor

Changes

Update to the new way the spawn command must be used, after the use of arrays was deprecated in Node.js 24 when the shell option is enabled,

ref: https://nodejs.org/api/deprecations.html#DEP0190, nodejs/node#57199 nodejs/help#5063 (comment)

closes: #14139

Testing

Before:
imagen

After:
imagen

Docs

No changes to the documentation are needed, it's just a minor change.

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
@changeset-bot

changeset-bot Bot commented Jul 30, 2025 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a225bdd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: create-astro Related to the `create-astro` package (scope) label Jul 30, 2025

@ascorbic ascorbic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ascorbic
ascorbic merged commit 89e9364 into withastro:main Jul 30, 2025
@astrobot-houston astrobot-houston mentioned this pull request Jul 30, 2025
@bjohansebas
bjohansebas deleted the fix-warning branch July 30, 2025 11:53
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
…#14158)

* fix: update spawn command to concatenate command and flags

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

* Update stupid-ways-tie.md

---------

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Co-authored-by: Matt Kane <m@mk.gg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: create-astro Related to the `create-astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NodeJS DEP0190 DeprecationWarning

2 participants