Skip to content

Refuse to overwrite a published release #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stonebig merged 1 commit into from
Sep 27, 2026
Merged

Refuse to overwrite a published release #2109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .github/workflows/build_winpython_cycle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ on:
required: false
default: true
type: boolean
overwrite_published:
description: 'Tick ONLY to replace the files of an already-published release; normally a release_level bump is what you want'
required: false
default: false
type: boolean

permissions: {}

Expand Down Expand Up @@ -81,10 +86,20 @@ jobs:
TAG: ${{ needs.config.outputs.release_tag }}
TITLE: ${{ needs.config.outputs.release_title }}
CYCLE: ${{ inputs.cycle }}
OVERWRITE: ${{ inputs.overwrite_published }}
run: |
if gh release view "$TAG" >/dev/null 2>&1; then
# re-running one missing flavor is normal; say which release its files
# land on, and leave the title alone in case it was edited by hand
# Adding a missing flavor to a draft is the normal path. Landing on
# a release that is already published is almost always a forgotten
# release_level bump, and the upload replaces files people have
# downloaded -- so stop here, before an hour of build time.
published=$(gh release view "$TAG" --json isDraft --jq '.isDraft | not')
if [ "$published" = "true" ] && [ "$OVERWRITE" != "true" ]; then
echo "::error::$TAG is already published. Bump release_level in cycles/$CYCLE.toml, or re-dispatch with overwrite_published ticked to replace its files."
exit 1
fi
# say which release the files land on, and leave the title alone in
# case it was edited by hand
state=$(gh release view "$TAG" --json isDraft --jq 'if .isDraft then "still a draft" else "ALREADY PUBLISHED" end')
echo "release $TAG exists ($state); this run adds its files to it"
else
Expand Down
Loading