Repository navigation
Conversation
jdm
approved these changes
Oct 15, 2026
jdm
enabled auto-merge (rebase)
October 15, 2026 13:59
auto-merge was automatically disabled
October 15, 2026 14:18
Pull request was closed
jdm
enabled auto-merge (rebase)
October 15, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypedArraysstore data using host-native byte order.On big-endian architectures (e.g.
s390x / ppc64 AIX),TypedArraybyte sequences read as aBlobproduce different byte orders than on little-endian architectures.This PR dynamically asserts the expected string based on host endianness so the tests pass across all platforms.
Before (in Big-Endian machine):
After(In Big-Endian machine):
References
FileAPIwpt nodejs/node#55194