docs: document the fzf Alt-C directory-search handoff - #816
Draft
hongyi-chen wants to merge 1 commit into
Draft
hongyi-chen wants to merge 1 commit into
hongyi-chen wants to merge 1 commit into
Conversation
warp#16094 extended the shell widget handoff to fzf's directory-search widget. The Command Search page already enumerated the Ctrl+R and Ctrl+T handoffs, so it was incomplete without it. Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
This PR was generated with Warp. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What this feature does
When your shell has fzf installed, pressing
⌥C(macOS) orAlt+C(Windows/Linux) at an idle prompt opens fzf's directory-search widget and changes directory to your selection. Warp previously handed off onlyCtrl+RandCtrl+T.Content design plan (short form)
command-search.mdxenumerates the handoff explicitly — "The same handoff applies toCtrl+T" — so a reader takes that list as complete. Omitting⌥Creads as "Warp does not hand off Alt-C," which is now wrong. The page also never distinguished fzf from atuin, though they get different key sets.### Handing off to fzfsubsection naming both extra keys, the fzf-only scope, the editable External Directory Search action, and the two cases where no handoff happens. Excludes fzf's own configuration (FZF_ALT_C_COMMAND,FZF_ALT_C_OPTS) — that is fzf's documentation, not ours.Gate verdict
Gate 1, update an existing page. The knob is a real editable keybinding rather than a shell detail:
workspace:trigger_external_alt_c_directory_search, display name External Directory Search, defaultalt-c(app/src/terminal/input.rs:2254-2256), context-gated byEXTERNAL_ALT_C_BINDING_CONTEXT(input.rs:446).Gate 0 clears:
shell_widget_handoffis a default cargo feature, and the change shipped in stablev0.2026.09.30.08.29.stable_01.Behavior verified at source rather than from the changelog bullet:
external_alt_c_binding_eligiblerequiresFZF_PLUGIN_TAGon the session's shell (app/src/terminal/view.rs:9672-9683), so atuin keeps theCtrl+Rhandoff and nothing else.⌥Cstill typesçin Vim on a macOS layout.warp_run_external_alt_c_widgetare present in all three integrations (zsh_body.sh:762,fish.sh:618,bash_body.sh:1004).The PR was marked
CHANGELOG-BUG-FIXupstream but surfaced under "Improvements" in the release; either way it adds a key the page's own list did not cover.Changes
terminal/entry/command-search.mdx— new### Handing off to fzfsubsection; theCtrl+Tclause moved out of the paragraph above it into that list.Reviewer
suggest_reviewers.pyresolved exactly one owning engineer for the shell bootstrap files behind this change, so a single review request went to them. The remaining paths resolve only to@warpdotdev/oss-maintainersvia the root rule, and teams are never requested.Deferred findings from this run
Listed in full on the ChatGPT subscription PR (#815) and the bookkeeping PR (#768). Nothing from this release was dropped without a recorded verdict.
Unverified claims
None. Every claim on the changed lines traces to a cited line in the public
warpdotdev/warpcheckout at38b2c55e4. No{/* VERIFY */}markers are present.Documentation risk
Risk: engineering-review-required
Rationale: Adds a keybinding claim, a named keybinding action, and platform-specific behavior for a shell integration.
Source files consulted: warp/app/src/terminal/input.rs@38b2c55e4, warp/app/src/terminal/view.rs@38b2c55e4, warp/app/src/workspace/view.rs@38b2c55e4, warp/app/assets/bundled/bootstrap/zsh_body.sh@38b2c55e4, warp/app/assets/bundled/bootstrap/fish.sh@38b2c55e4, warp/app/assets/bundled/bootstrap/bash_body.sh@38b2c55e4
Requested engineering reviewers: zachbai
Engineering review status: pending
Docs override: none
Plans: