fix: repair broken changelog links for Markdown Viewer entry - #788
warp-factories[bot] wants to merge 2 commits into
Conversation
PR #12866 no longer resolves on warpdotdev/warp, and the @fadexadex profile is gone. Point the entry at the surviving public commit and keep the contributor credit as plain text.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR was generated with Warp. Comment |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR repairs the 2026 changelog entry for the Markdown Viewer preference fix by retargeting a dead PR link to a commit URL and removing a deleted contributor profile hyperlink.
Concerns
- No blocking concerns found. The attached spec context contains no approved or repository spec to validate against, and the security pass did not identify issues in this link-only documentation change.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
src/content/docs/changelog/2026.mdx:500— [SUGGESTION] Link text#12866still reads as a PR reference but now points tohttps://github.com/warpdotdev/warp/commit/6b01a8e2fa372498c78e2c777b8006db6a86ca8b(a bare commit page), because PR #12866 itself 404s (verified live). Requested change: optionally reword the link label/context so readers aren't surprised the click lands on a commit diff instead of a PR conversation; not blocking since the retarget itself is factually correct.- PR description, Summary section — [NIT] The claim that plain-text
@fadexadex"match[es] other changelog rows where a profile link is unavailable" is imprecise: the plain-@userprecedent rows in2026.mdx(e.g. lines ~994-1107) predate the[@user](url)linking convention rather than reflecting dead profiles —@lonexrebappears both linked (line 510) and unlinked (line 1049) elsewhere in the same file. Requested change: tighten the rationale wording if this reasoning is reused as precedent in future link-repair PRs; does not affect the shipped changelog content.
Verdict
Approve with nits
This branch was successfully deployed
1 participant
Summary
Repairs two broken external links in the 2026 changelog entry for the Markdown Viewer preference fix. Public PR
#12866no longer resolves onwarpdotdev/warp, and the@fadexadexGitHub profile is gone (HTTP 404). The entry now links to the surviving public commit and keeps the contributor credit as plain text, matching other changelog rows where a profile link is unavailable.Related issues
None
Changes
src/content/docs/changelog/2026.mdx#12866fromhttps://github.com/warpdotdev/warp/pull/12866tohttps://github.com/warpdotdev/warp/commit/6b01a8e2fa372498c78e2c777b8006db6a86ca8b[@fadexadex](https://github.com/fadexadex)with plain@fadexadexValidation
python3 .agents/skills/check_for_broken_links/check_links.pyScreenshots
None
Follow-ups
warpdotdev/channel-versionschannel_versions.jsonfor this release entry. Docs matched that source 1:1 when the entry was published; consider updating channel-versions so future syncs do not reintroduce the broken links.Documentation risk
Risk: low
Rationale: Link-only fix in the public changelog: retarget a dead PR URL to the surviving public commit and drop a deleted GitHub profile hyperlink.
Docs override: none
Unverified claims
None. Both replacement targets were verified with live HTTP/API checks (commit URL returns 200; user and PR URLs return 404).