Mirror x-omitempty filtering in OpenAPI sync fallback - #781
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
warp-agent-staging
Bot
added
factory:wilson
warpy-factory
|
This PR was generated with Warp. Comment    |
|
@warp-agent-staging[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR mirrors the upstream OpenAPI fallback filtering by adding x-omitempty to the recursive implementation-only extension strip list and extending the self-test fixture so the existing strip assertion covers it.
Concerns
- No blocking correctness, security, comment-quality, test-quality, or spec-drift concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
.agents/skills/sync-openapi-spec/scripts/sync_openapi.py:81— [IMPORTANT] DeclaredRisk: low, but this PR manually editsSTRIP_FLAGS(governs what's stripped from the publicdevelopers/agent-api-openapi.yaml) based on an unverifiable claim about warp-server's privatepublic_api/public-openapi-filter.yamlstripFlags list, with noSource files consultedorRequested engineering reviewersfield. Persync-openapi-spec/SKILL.md, a manual (non-passthrough) edit to the sync policy isengineering-review-required. Requested resolution: reclassify asRisk: engineering-review-required, cite the warp-server source file/SHA underSource files consulted, and request review from a warp-server owner who can confirmx-omitemptyis in the upstreamstripFlagslist..agents/skills/sync-openapi-spec/scripts/sync_openapi.py:81— [IMPORTANT] Addingx-omitemptytoSTRIP_FLAGSmakes.agents/skills/sync-openapi-spec/references/sync-policy.md:55-59(which enumeratesSTRIP_FLAGSas mirroring warp-server's stripFlags 'verbatim') stale, and skips that doc's own instruction at lines 76-77 to add new upstream strip-flag entries there too so the two filters 'stay in lockstep.' Requested resolution: updatereferences/sync-policy.md's STRIP_FLAGS enumeration and lockstep note to includex-omitemptyin this same PR.
Verdict
Request changes
Summary
Mirror the authoritative OpenAPI filter's
x-omitemptyhandling in the docs repository's manual sync fallback. This prevents implementation-only serialization hints from reaching the public Agent API spec when the fallback path is used.Related issues
Context: warpdotdev/warp-server#18081
Validation
python3 .agents/skills/sync-openapi-spec/scripts/sync_openapi.py --mode self-test(self-test: OK)python3 -m py_compile .agents/skills/sync-openapi-spec/scripts/sync_openapi.pygit diff --checktrunk fmtnot run because the Trunk CLI is unavailable in this environment.Screenshots
Not applicable; this changes internal sync tooling only.
Follow-ups
None.
Documentation risk
Risk: low
Rationale: Mirrors an implementation-only OpenAPI strip flag in internal docs tooling.
Docs override: none
Unverified claims
None.