feat(operator): Add explicit manifest workload security profiles - #381
Draft
casey-coreweave wants to merge 1 commit into
Draft
casey-coreweave wants to merge 1 commit into
casey-coreweave wants to merge 1 commit into
Conversation
| Triage *ApplicationTriage `yaml:"triage,omitempty"` | ||
| // SecurityProfile opts this workload into security settings supported by | ||
| // newer server images. A nil or empty profile preserves legacy behavior. | ||
| SecurityProfile *WorkloadSecurityProfile `yaml:"securityProfile,omitempty"` |
Contributor
There was a problem hiding this comment.
would it make sense to make this not be a pointer, since all the values within are pointers it would reduce the amount of nil checks needed, assuming that new values will be added within the struct those might always need explicit behaviors for nil values, it should reduce the complexity abit to remove the outer nil check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server images differ in whether they support non-root execution and a read-only
root filesystem. Add an explicit per-application and per-migration server-manifest
contract so Core can select compatible workloads without changing older releases
based on their version string.
securityProfile.runAsNonRootandsecurityProfile.readOnlyRootFilesystemareoptional booleans. Omitted/empty profiles preserve legacy rendering; explicit
falseis retained. Application profiles cover all containers and init containers.Migration profiles apply to newly created Jobs without restarting completed
migrations. No numeric pod identity is introduced.
Application fragments merge profile fields in filename order; later explicit
values win. Migration definitions retain their existing whole-entry replacement
semantics. Documentation includes examples, rollback behavior, and image/runtime
requirements. Current Watchtower triage fields and baseline contexts are preserved.
Validation:
fragments, sizing merge, version independence, single/multiple/init containers,
migration rendering, completed migrations, and stable reconciliation/rollback.
make testandmake buildpassed, including vet. Chart dependencies wereresolved locally; no Chart.lock or generated API changes.
definitions remain unprofiled; application rendering is unchanged across tested
server versions.
Test output
Selected excerpts from saved validation logs (not a complete log):