Skip to content

Clarify build process - #5

Merged
w0rthy merged 2 commits into
w0rthy:masterfrom
Zoybean:build-process
Jan 16, 2019
Merged

w0rthy merged 2 commits into
w0rthy:masterfrom
Zoybean:build-process

Conversation

@Zoybean

@Zoybean Zoybean commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

Add build and run instructions to README
Add jar manifest
Ignore .class and .jar files
Remove compiled jar from repository

Solution to issue #3, working off of @Skeen's changes

Add build and run instructions to README
Add jar manifest
Ignore .class and .jar files
Remove compiled jar from repository
@w0rthy

w0rthy commented Jan 7, 2019

Copy link
Copy Markdown
Owner

I'm presuming the reasons for not hosting the compiled program are security/trust related?

@Skeen

Skeen commented Jan 7, 2019

Copy link
Copy Markdown
Contributor

Compiled programs should be released as releases.

@Zoybean

Zoybean commented Jan 7, 2019

Copy link
Copy Markdown
Contributor Author

My understanding is that git is primarily designed to manage text files, and also that compiled classes, binaries, and jars are redundant when the source is managed. Whenever you update the source, you'd have to either remember to recompile and commit those assets, or have a commit where the program doesn't match its source.

@w0rthy
w0rthy merged commit 904fc84 into w0rthy:master Jan 16, 2019
@w0rthy

w0rthy commented Jan 16, 2019

Copy link
Copy Markdown
Owner

I understand your reasoning, however I was providing it for convenience. Will try the release system instead.

meetinger referenced this pull request in meetinger/ArrayVisualizerOutdated Apr 2, 2020
meetinger referenced this pull request in meetinger/ArrayVisualizerOutdated Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants