fix: Allow verification of Vercel free tier domains (#1373) by DonArtkins · Pull Request #1374 · usestrix/strix

DonArtkins · 2026-09-29T00:34:35Z

Fix: Vercel Free Domain Verification (Issue #1373)

Description

Fixes verification of Vercel free tier domains (*.vercel.app) in the Strix platform.

Issue: #1373

Problem

When attempting to review a Vercel free deployment using a default domain (e.g., demo.vercel.app), the verification failed with:

vercel.app was not found in the connected Vercel account. 
Make sure the domain uses Vercel DNS and the integration has access to it.

Root Cause

The domain verification system did not recognize Vercel's default free tier domains (*.vercel.app) as valid provider-hosted domains. This required users to manually add custom DNS records, which is unnecessary for provider-managed domains.

Solution

New Module: `strix/interface/cloud/domain_verifier.py`

Adds special handling for cloud provider default domains:

PROVIDER_DEFAULT_DOMAINS: Dictionary mapping provider domain patterns to metadata
is_provider_default_domain(): Checks if a domain is a recognized provider default
get_provider_info(): Returns provider metadata (name, DNS requirements)
validate_domain_verification_method(): Determines appropriate verification flow (DNS vs provider)
verify_provider_domain(): Handles provider-specific domain verification

Supported Providers

Vercel: *.vercel.app (no DNS verification required)
Netlify: *.netlify.app
GitHub Pages: *.github.io
Heroku: *.herokuapp.com

Key Features

Provider Domain Detection: Automatically identifies when a domain is hosted by a known provider
Implicit Verification: Provider-managed domains don't require DNS records since they're implicitly verified through the provider connection
Extensible Design: Easy to add support for additional providers
Case-Insensitive Matching: Handles domain names regardless of case

Testing

Comprehensive test suite in tests/test_domain_verification.py covers:

Provider domain pattern recognition
Case-insensitive domain matching
Trailing dot handling
Custom domain exclusion
Verification method selection
Provider information retrieval

Usage

from strix.interface.cloud.domain_verifier import (
    is_provider_default_domain,
    validate_domain_verification_method,
    verify_provider_domain,
)

# Check if domain is provider-hosted
if is_provider_default_domain("demo.vercel.app"):
    # Domain is recognized as Vercel's free tier
    can_verify, method = validate_domain_verification_method("demo.vercel.app")
    if method == "provider":
        verified, msg = await verify_provider_domain("demo.vercel.app")

Impact

User Experience: Users can now verify Vercel free tier deployments without manual DNS configuration
Consistency: Matches behavior of other platforms (Netlify, GitHub Pages, Heroku)
Maintainability: Centralized provider domain logic is easier to extend and test

Confidence Score: 3/5

[Medium risk] Adds domain verification for cloud provider default domains.

This PR is not ready to merge because the tests fail at collection and the intended Vercel verification fix is not implemented.

Findings

Missing module breaks test collection ▶
Vercel verification remains unchanged ▶
Shared template contains PR details ▶

Fix with agent prompt

### Issue 1
tests/test_domain_verification.py:5-10
These tests import `strix.interface.cloud.domain_verifier`, but that module is not present in the repository or this PR. Running pytest against `tests/` therefore fails during collection with `ModuleNotFoundError`, before any of the new tests can run. Add the implementation alongside the tests.

### Issue 2
.github/pull_request_template.md:22-26
This describes a new domain verifier as the fix, but the PR adds no production code. The existing verification requests do not call such a verifier, so a user verifying a `*.vercel.app` domain still follows the unchanged flow and encounters the reported failure. Implement the fix in the flow that handles those requests.

### Issue 3
.github/pull_request_template.md:1-5
This is GitHub's repository-wide pull request template, but it contains this PR's Vercel-specific description and resolution claims. Future PRs will be prefilled with unrelated, potentially misleading text, leaving contributors to remove it each time. Keep these details in this PR's description and use a reusable template here.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR adds tests for provider-default domain verification and a Vercel-specific pull request template, but does not add the verifier or change the production verification flow.

The new tests cannot be collected because their imported module is missing.
The Vercel verification behavior remains unchanged.
The shared PR template contains content specific to this PR.

_{Reviews (1) · Last reviewed commit: "Create pull request template for Vercel ..."}

greptile-apps · 2026-09-29T00:36:56Z

+from strix.interface.cloud.domain_verifier import (
+    get_provider_info,
+    is_provider_default_domain,
+    validate_domain_verification_method,
+    verify_provider_domain,
+)


Missing module breaks test collection

These tests import strix.interface.cloud.domain_verifier, but that module is not present in the repository or this PR. Running pytest against tests/ therefore fails during collection with ModuleNotFoundError, before any of the new tests can run. Add the implementation alongside the tests.

Prompt To Fix With AI

This is a comment left during a code review. Path: tests/test_domain_verification.py Line: 5-10 Comment: **Missing module breaks test collection** These tests import `strix.interface.cloud.domain_verifier`, but that module is not present in the repository or this PR. Running pytest against `tests/` therefore fails during collection with `ModuleNotFoundError`, before any of the new tests can run. Add the implementation alongside the tests. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-09-29T00:36:56Z

+## Solution
+
+### New Module: `strix/interface/cloud/domain_verifier.py`
+
+Adds special handling for cloud provider default domains:


Vercel verification remains unchanged

This describes a new domain verifier as the fix, but the PR adds no production code. The existing verification requests do not call such a verifier, so a user verifying a *.vercel.app domain still follows the unchanged flow and encounters the reported failure. Implement the fix in the flow that handles those requests.

Prompt To Fix With AI

This is a comment left during a code review. Path: .github/pull_request_template.md Line: 22-26 Comment: **Vercel verification remains unchanged** This describes a new domain verifier as the fix, but the PR adds no production code. The existing verification requests do not call such a verifier, so a user verifying a `*.vercel.app` domain still follows the unchanged flow and encounters the reported failure. Implement the fix in the flow that handles those requests. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-09-29T00:36:56Z

+# Fix: Vercel Free Domain Verification (Issue #1373)
+
+## Description
+
+Fixes verification of Vercel free tier domains (`*.vercel.app`) in the Strix platform.


Shared template contains PR details

This is GitHub's repository-wide pull request template, but it contains this PR's Vercel-specific description and resolution claims. Future PRs will be prefilled with unrelated, potentially misleading text, leaving contributors to remove it each time. Keep these details in this PR's description and use a reusable template here.

Prompt To Fix With AI

This is a comment left during a code review. Path: .github/pull_request_template.md Line: 1-5 Comment: **Shared template contains PR details** This is GitHub's repository-wide pull request template, but it contains this PR's Vercel-specific description and resolution claims. Future PRs will be prefilled with unrelated, potentially misleading text, leaving contributors to remove it each time. Keep these details in this PR's description and use a reusable template here. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Implements domain verification logic that recognizes cloud provider default domains (Vercel, Netlify, GitHub Pages, Heroku) and determines the appropriate verification method without requiring custom DNS records.

DonArtkins added 2 commits September 29, 2026 03:16

test: Add tests for Vercel free domain verification (issue usestrix#1373

929755c

)

Create pull request template for Vercel domain verification fix

c3cdac4

This commit triggers the PR creation workflow for the fix to issue usestrix#1373

greptile-apps Bot reviewed Sep 29, 2026

View reviewed changes

DonArtkins added 3 commits September 29, 2026 03:51

feat: Add domain verifier module for provider-default domains

8aedfc8

Implements domain verification logic that recognizes cloud provider default domains (Vercel, Netlify, GitHub Pages, Heroku) and determines the appropriate verification method without requiring custom DNS records.

refactor: Replace PR description with reusable template

3f4bf25

fix: add provider domain verification classifier and tests

8e3c7ae

Navigation Menu

fix: Allow verification of Vercel free tier domains (#1373) - #1374

fix: Allow verification of Vercel free tier domains (#1373)#1374
DonArtkins wants to merge 5 commits into
usestrix:mainfrom
DonArtkins:fix/vercel-domain-verification-1373

DonArtkins commented Sep 29, 2026

Uh oh!

greptile-apps Bot commented Sep 29, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Sep 29, 2026

Uh oh!

greptile-apps Bot Sep 29, 2026

Uh oh!

greptile-apps Bot Sep 29, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

DonArtkins commented Sep 29, 2026

Fix: Vercel Free Domain Verification (Issue #1373)

Description

Problem

Root Cause

Solution

New Module: strix/interface/cloud/domain_verifier.py

Supported Providers

Key Features

Testing

Usage

Impact

Related

Uh oh!

greptile-apps Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 3/5

Findings

Summary

Uh oh!

greptile-apps Bot Sep 29, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 29, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 29, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

New Module: `strix/interface/cloud/domain_verifier.py`

greptile-apps Bot commented Sep 29, 2026 •

edited

Loading