Skip to content

lazily load uuid lib only where needed - #1270

Merged
Lukasa merged 1 commit into
urllib3:masterfrom
igalic:lazyload-uuid
Sep 21, 2017
Merged

Lukasa merged 1 commit into
urllib3:masterfrom
igalic:lazyload-uuid

Conversation

@igalic

@igalic igalic commented Sep 20, 2017

Copy link
Copy Markdown
Contributor

This should address issues such as psf/requests#3213 in downstream libraries.

@sigmavirus24

Copy link
Copy Markdown
Contributor

Could you add a note to our CHANGES file regarding this? Once that's there, I'm 👍

@codecov-io

codecov-io commented Sep 20, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #1270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1270   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          21      21           
  Lines        1985    1985           
======================================
  Hits         1985    1985
Impacted Files Coverage Δ
urllib3/filepost.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e4245...582db1f. Read the comment docs.

@igalic

igalic commented Sep 20, 2017

Copy link
Copy Markdown
Contributor Author

@sigmavirus24 unless this is a breaking change, it's now documented in CHANGES.
Is there anything I can do to address the codecoverage drop?

@igalic

igalic commented Sep 20, 2017

Copy link
Copy Markdown
Contributor Author

fascinating.
i added a CHANGES entry, and now everything is failing 🤣

@sigmavirus24

Copy link
Copy Markdown
Contributor

@igalic, I'm not sure what you mean about the drop in coverage, I see:

Merging #1270 into master will not change coverage.

I think codecov is marked as failed because AppVeyor failed. I'll see if I can restart that build.

@sigmavirus24

Copy link
Copy Markdown
Contributor

And I can't. I don't know who can. 😞

@sethmlarson

Copy link
Copy Markdown
Member

Does AppVeyor react to a close->open like Travis does?

@igalic

igalic commented Sep 20, 2017

Copy link
Copy Markdown
Contributor Author

i did a push --force perhaps that confused AppVeyor & codecov?

@igalic igalic closed this Sep 20, 2017
@igalic igalic reopened this Sep 20, 2017
@igalic

igalic commented Sep 20, 2017

Copy link
Copy Markdown
Contributor Author

looking better now!

@sethmlarson

Copy link
Copy Markdown
Member

🎉 Glad the close-open trick worked. :)

@igalic

igalic commented Sep 21, 2017

Copy link
Copy Markdown
Contributor Author

n.b.: This optimization might be obsoleted thru python/cpython#3684

@Lukasa Lukasa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, even though an optimisation may mean we don't need this on newer versions of CPython, we support way more than just that. Thanks for this! ✨

@Lukasa
Lukasa merged commit cbde04b into urllib3:master Sep 21, 2017
@igalic
igalic deleted the lazyload-uuid branch September 21, 2017 21:47
Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
lazily load uuid lib only where needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants