Repository navigation
lazily load uuid lib only where needed - #1270
Conversation
|
Could you add a note to our CHANGES file regarding this? Once that's there, I'm 👍 |
Codecov Report
@@ Coverage Diff @@
## master #1270 +/- ##
======================================
Coverage 100% 100%
======================================
Files 21 21
Lines 1985 1985
======================================
Hits 1985 1985
Continue to review full report at Codecov.
|
|
@sigmavirus24 unless this is a breaking change, it's now documented in CHANGES. |
|
fascinating. |
|
@igalic, I'm not sure what you mean about the drop in coverage, I see: I think codecov is marked as failed because AppVeyor failed. I'll see if I can restart that build. |
|
And I can't. I don't know who can. 😞 |
|
Does AppVeyor react to a close->open like Travis does? |
|
i did a |
|
looking better now! |
|
🎉 Glad the close-open trick worked. :) |
|
n.b.: This optimization might be obsoleted thru python/cpython#3684 |
Lukasa
left a comment
There was a problem hiding this comment.
Cool, even though an optimisation may mean we don't need this on newer versions of CPython, we support way more than just that. Thanks for this! ✨
lazily load uuid lib only where needed
This should address issues such as psf/requests#3213 in downstream libraries.