fix(autodiscovery/updatecli): correctly use relative file path - #9759
Merged
Merged
Conversation
Signed-off-by: Olblak <me@olblak.com>
olblak
enabled auto-merge (squash)
July 31, 2026 07:53
olblak
added
the
skip-changelog
Member
Author
|
Next error can be reproduced running Which return |
Signed-off-by: Olblak <me@olblak.com>
olblak
changed the title
olblak
added
bug
Signed-off-by: Olblak <me@olblak.com>
Member
Author
|
I can't reproduce the gitea issue locally I am suspecting an issue on the github runner |
This was referenced Aug 25, 2026
olblak
added a commit
that referenced
this pull request
Aug 26, 2026
…fests (#10109) * fix(autodiscovery/helmfile): use relative file path in generated manifests The File field in the generated condition and target was set to foundHelmfile (absolute path within the SCM clone) instead of relativeFoundChartFile. This caused every helmfile-derived pipeline to fail at the condition step with: init yaml files: absolute path "..." is not allowed: files must stay within the working directory "..." As a result the target was always skipped, silently preventing any helmfile release from being updated. ManifestName and ConditionName already used relativeFoundChartFile correctly — File was the only field that did not. Fixes #10108 Related to #9759, which fixed the identical pattern in the updatecli autodiscovery plugin. * test(autodiscovery/helmfile): fix expected file paths after relative path fix Update test expectations to match the new behavior introduced in aaba087: file paths in generated manifests are now relative to rootDir, not to the test's working directory. --------- Co-authored-by: Olivier Vernin <olivier@vernin.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement