Skip to content

chore: move updatecli manifest validate out of experimental - #10586

Merged
olblak merged 3 commits into
updatecli:mainfrom
olblak:validate/no/experimental
Sep 25, 2026
Merged

chore: move updatecli manifest validate out of experimental#10586
olblak merged 3 commits into
updatecli:mainfrom
olblak:validate/no/experimental

Conversation

@olblak

@olblak olblak commented Sep 24, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Move updatecli manifest validate not experimental anymore

Test

To test this pull request, you can run the following commands:

make test

Additional Information

Checklist

  • I have updated the documentation via pull request in website repository.
  • I have tested this pull request manually with a custom Updatecli build and it works as expected.

Tradeoff

Potential improvement

Summary by CodeRabbit

  • Changes
    • manifest validate is no longer marked experimental and can be run without the --experimental flag.
    • Manifest schema validation and its warning behavior are unchanged.

@olblak olblak added the enhancement New feature or request label Sep 24, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: cb82a633-6684-4f41-b476-d0a478064407

📥 Commits

Reviewing files that changed from the base of the PR and between 2b977d7 and 0433683.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: eade2049-26ae-4036-9279-15a4267d97b6

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe4cac and 2b977d7.

📒 Files selected for processing (3)
  • cmd/manifest_validate.go
  • e2e/scripts/test_manifest_validate.bash
  • e2e/scripts/test_manifest_validate_invalid.bash

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

The manifest validate command no longer requires experimental mode. Its help text no longer labels the command as experimental. Both end-to-end test scripts run the command without the --experimental flag.

Changes

Manifest validation availability

Layer / File(s) Summary
Run manifest validation without experimental mode
cmd/manifest_validate.go, e2e/scripts/test_manifest_validate.bash, e2e/scripts/test_manifest_validate_invalid.bash		 The command proceeds to its existing validation flow without the experimental-mode check. Its help text no longer labels the command as experimental. Both end-to-end invocations omit the --experimental flag.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 2b977

Manifest validation is available without experimental mode, and the E2E suite includes checks for both valid and invalid manifests. No actionable merge risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: moving updatecli manifest validate out of experimental status.
Description check ✅ Passed The description explains the change, includes a test command, and retains the required template sections. The issue reference, tradeoff, and potential improvement sections are not filled in, but the d…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@olblak
olblak enabled auto-merge (squash) September 24, 2026 19:29
@olblak
olblak merged commit 7e73171 into updatecli:main Sep 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@olblak