Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vue3, jsx and qwik compilers load their peer dependency with
importModule('@vue/compiler-sfc')etc. Since local-pkg 1.x,importModule(name)is a plainimport(name)evaluated inside local-pkg, so the peer is resolved relative to local-pkg's location. That only works when the peer is hoisted next to local-pkg.With Bun's isolated linker + global store (
globalStore = truein bunfig.toml), local-pkg lives in~/.bun/install/cache/links/local-pkg@…/and only sees its own dependencies, so a Slidev build fails with:The peer is linked next to unplugin-icons itself though (it is a declared optional peer), so this PR resolves the module from unplugin-icons first (
import.meta.url) and falls back to the project cwd, then imports the resolved path. The three compilers share a smallimportPeerModulehelper.Verified with a Slidev deck installed by Bun 1.4.0 with the global store: 5 errors before, builds fine with the patched dist.
pnpm lint,pnpm test(added a small test for the vue3 compiler) andpnpm buildpass;pnpm typecheckfails on main already for an unrelatedAwaitablemismatch.