Conversation
Flo4604
added this pull request to stack #7678
October 1, 2026 11:07
Add deletion timestamps and transactional parent guards. Keep the data APIs separate from the consumers added later in the cleanup stack. Apply the additive schema changes before deploying the control services. Amp-Thread-ID: https://ampcode.com/threads/T-01a0c960-4827-7091-bd71-bb8b7aa78f9c Co-authored-by: Amp <amp@ampcode.com>
Flo4604
force-pushed
the
cleanup/deletion-data
branch
from
October 1, 2026 11:28
9c3921e to
74b5e17
Compare
Delete domain challenges and owned certificates together, and remove unreferenced autoscaling policies with regional settings. Add queries for portal descendants, current-deployment references, and writer locks. Amp-Thread-ID: https://ampcode.com/threads/T-01a0c960-4827-7091-bd71-bb8b7aa78f9c Co-authored-by: Amp <amp@ampcode.com>
Flo4604
marked this pull request as ready for review
October 2, 2026 13:10
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current way of deleting projects/apps/environments isnt that safe to actually
A) ensure everything deletes delete from the DB
B) compute is stopped correctly
So for now we are adding deletion timestamps so we know about the intent of having to delete something with this we can also block writes that happen to the same resource we want to delete
This pr is just about queries/schema/ code regens