Conversation
Store app bindings by source app and environment. Select live production, matching previews, or pinned deployments without crossing tenant scope. Keep first-ready history so failed starts cannot become discovery targets. Amp-Thread-ID: https://ampcode.com/threads/T-01a0867e-f00a-7718-961d-5d9cf2250eaf Co-authored-by: Amp <amp@ampcode.com>
Read bindings and replicas in stable keyset pages. Keep filters before the page limit so an excluded workspace cannot truncate the snapshot. Reserve the app slug for replica discovery and index enrollment and deployment pins. Amp-Thread-ID: https://ampcode.com/threads/T-01a0867e-f00a-7718-961d-5d9cf2250eaf Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0867e-f00a-7718-961d-5d9cf2250eaf Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0867e-f00a-7718-961d-5d9cf2250eaf Co-authored-by: Amp <amp@ampcode.com>
Flo4604
added this pull request to stack #7655
September 30, 2026 08:28
Flo4604
changed the title
This was referenced Sep 30, 2026
Flo4604
changed the title
The conditional status update used by Deploy left first_ready_at NULL. Preview binding discovery requires that timestamp, so successful Git previews were excluded from DNS. Preserve the first timestamp and the existing guard against cancellation and compensation races. Amp-Thread-ID: https://ampcode.com/threads/T-01a0867e-f00a-7718-961d-5d9cf2250eaf Co-authored-by: Amp <amp@ampcode.com>
Use successful finalizing steps as durable proof for historical deployments and current ready status as a fallback. Preserve existing markers and document the two-pass rollout before readers are enabled. Amp-Thread-ID: https://ampcode.com/threads/T-01a0867e-f00a-7718-961d-5d9cf2250eaf Co-authored-by: Amp <amp@ampcode.com>
The pinned mysql2 prepared-statement path rejects the LIMIT parameter on MySQL 9.4. Keep parameter escaping through query and verify the real batched backfill and idempotent rerun against disposable MySQL data. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0867e-f00a-7718-961d-5d9cf2250eaf
A completed finalizing step can race with a stop and never write ready. Only backfill rows still ready. Report ambiguous history and fail the migration command so readers remain gated on an operator review. Exercise bounded updates, reruns, and both CLI exit paths on MySQL. Amp-Thread-ID: https://ampcode.com/threads/T-01a0867e-f00a-7718-961d-5d9cf2250eaf Co-authored-by: Amp <amp@ampcode.com>
Flo4604
changed the title
Amp-Thread-ID: https://ampcode.com/threads/T-01a0867e-f00a-7718-961d-5d9cf2250eaf Co-authored-by: Amp <amp@ampcode.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
App connections need explicit caller and target ownership, stable names, and rules for selecting a deployment.
Solution:
Add the database foundation for app connections. Keep target selection within project, environment, branch, and fork boundaries. Record whether a deployment has reached ready and support connection cleanup.
Impact:
This layer does not activate private networking. Schema rollout and historical readiness backfill require separate operational checks. Later layers add lifecycle protection, discovery, network access, DNS, and the dashboard. The stack's naming layer changes the remaining internal identifiers to connections.
Testing:
Earlier combined-stack build and lint passed. Targeted verification included database selection and shared connection rules. An earlier local combined-stack run passed 397 targeted Go tests; migration tests passed 7 cases on disposable MySQL. Final combined-stack verification passed:
GOMAXPROCS=4 GOFLAGS=-p=2 mise run test --concurrency 2completed 318 suites with 25,790 passed, 0 failed, and 7,875 ignored tests (195 suites cached).mise run buildpassed; lint reported 0 issues. No production migration was run.