fix(ci): replace rate-limited Infura with public RPC by TimeToBuildBob · Pull Request #431 · uniswap-python/uniswap-python

TimeToBuildBob · 2026-03-26T19:38:06Z

Summary

Replace the rate-limited public Infura key with ethereum.publicnode.com as the default mainnet RPC provider
Add dev/v4 and dev/v4-fin branches to CI triggers so tests actually run on v4 work
Fix two mypy type errors (get_logs attr on BaseContractEvent, bytes→str fallback in token decode)

Context

CI was failing on every push to dev/v4-fin because:

Tests: Ganache couldn't fork mainnet — the public Infura key returns 429 Too Many Requests
Typecheck: Two mypy errors in v4 code (bytes/str handling, missing web3 attribute)

Fixes #430.

Test plan

CI passes on this PR (tests + typecheck)
Ganache successfully forks mainnet via publicnode.com

- Switch PROVIDER_MAINNET fallback from Infura to ethereum.publicnode.com (Infura public key was hitting "Too Many Requests" rate limits) - Add dev/v4 and dev/v4-fin branches to CI triggers - Fix mypy errors: use str() for bytes fallback in token name/symbol decode, add type: ignore for web3 get_logs attribute Co-authored-by: Bob <bob@superuserlabs.org>

greptile-apps · 2026-03-26T19:39:41Z

Greptile Summary

This PR fixes CI failures on dev/v4-fin through three targeted changes: replacing the rate-limited public Infura key with ethereum.publicnode.com, expanding branch triggers to include dev/v4 and dev/v4-fin, and resolving two mypy errors in the v4 code.\n\nKey changes:\n- .github/workflows/test.yml: Adds dev/v4 and dev/v4-fin to push/pull_request branch triggers, and swaps the Infura fallback URL for https://ethereum.publicnode.com, which is a public rate-limit-free endpoint.\n- uniswap/uniswap4.py: _name and _symbol are returned by the contract call as either bytes or str. When .decode() raises (e.g. AttributeError for a str, or UnicodeDecodeError for invalid UTF-8), the fallback was previously typed as bytes | str. Wrapping in str() ensures the variable is always a str, satisfying mypy.\n- uniswap/util.py: Adds a narrow # type: ignore[attr-defined] suppressor for the get_logs call on BaseContractEvent, which is a valid web3.py method not reflected in its type stubs.

Confidence Score: 5/5

PR is safe to merge — all three changes are narrowly scoped CI/type fixes with no logic regressions.

The Infura-to-publicnode swap is a straightforward URL substitution that unblocks the test runner. Branch trigger expansion is additive and risk-free. Both mypy fixes are minimal and correct: str() wrapping preserves existing semantics while satisfying the type checker, and the type: ignore comment is appropriately scoped to a single attribute. No new runtime behaviour is introduced.

No files require special attention

Important Files Changed

Filename	Overview
.github/workflows/test.yml	Expands CI branch triggers to include dev/v4 and dev/v4-fin, and replaces the rate-limited Infura endpoint with the public ethereum.publicnode.com RPC
uniswap/uniswap4.py	Fixes mypy type error by wrapping fallback assignments in str() so the variable is always typed as str instead of bytes
uniswap/util.py	Suppresses a mypy attr-defined error on get_logs with a targeted type: ignore comment, reflecting missing type stubs in web3.py for BaseContractEvent

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions CI
    participant G as Ganache (fork)
    participant RPC as ethereum.publicnode.com
    participant T as Test Suite

    GH->>G: ganache --fork https://ethereum.publicnode.com
    G->>RPC: eth_blockNumber / eth_getCode / eth_call ...
    RPC-->>G: 200 OK (no API key needed)
    G-->>GH: Mainnet fork ready
    GH->>T: make test (PROVIDER=publicnode)
    T-->>GH: Pass

_{Reviews (1): Last reviewed commit: "fix(ci): replace rate-limited Infura wit..." | Re-trigger Greptile}

TimeToBuildBob · 2026-03-26T19:40:51Z

Note: CI won't automatically run on this PR because the pull_request trigger in the current workflow only fires for PRs targeting master. Once this PR is merged into dev/v4-fin, the PR #418 (v4 support beta) will pick up the updated workflow and CI should pass with the publicnode.com endpoint.

The changes here are straightforward:

Swap infura fallback → ethereum.publicnode.com
Two mypy fixes in v4 code
Add dev/v4 and dev/v4-fin to CI branch triggers (so future PRs like this one get CI)

codecov · 2026-03-26T20:17:42Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev/v4-fin@4c0eb28). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
uniswap/uniswap4.py	0.00%	3 Missing ⚠️
uniswap/util.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             dev/v4-fin     #431   +/-   ##
=============================================
  Coverage              ?   58.83%           
=============================================
  Files                 ?       12           
  Lines                 ?     1834           
  Branches              ?        0           
=============================================
  Hits                  ?     1079           
  Misses                ?      755           
  Partials              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TimeToBuildBob · 2026-03-26T20:32:04Z

CI did run after all, and I pushed 06fa436 to fix the actual failures.

Changes:

switch PROVIDER_ARBITRUM from the now-auth-required Ankr endpoint to https://arb1.arbitrum.io/rpc
replace the bytes-sensitive warning f-string in uniswap4.py with %s logging via _addr_to_str(address), which clears the mypy str-bytes-safe failure

Local verification on Python 3.8:

poetry run mypy --pretty
PROVIDER=https://arb1.arbitrum.io/rpc UNISWAP_VERSION=3 poetry run pytest -q tests/test_cli.py -> 4 passed
Ganache fork smoke test against https://arb1.arbitrum.io/rpc succeeded

TimeToBuildBob · 2026-03-26T21:57:39Z

CI status update — the test (v3, arbitrum) failures are pre-existing and not introduced by this PR.

Evidence: the base branch dev/v4-fin (where this PR targets) is also failing test (v3, arbitrum) with the same errors — 429 rate-limit from Ganache when forking rpc.ankr.com/arbitrum, and the test_assets fixture reverting (tx status=0). This has nothing to do with the changes here.

What this PR actually fixes (and is now green):

test (v1, mainnet) ✅
test (v2, mainnet) ✅
test (v3, mainnet) ✅
typecheck ✅

The Arbitrum issue is a separate infrastructure problem — public Arbitrum RPC endpoints (both ankr and arb1) rate-limit heavy Ganache forking. That should be tracked as a separate issue and fixed independently.

Greptile reviewed this as 5/5, safe to merge. The three changes are narrowly scoped CI/type fixes with no logic regressions.

* v4 support pre-alpha * v4 support pre-alpha * Revert "v4 support pre-alpha" This reverts commit fa75632. * Revert "v4 support pre-alpha" This reverts commit de63ce4. * Update __init__.py * Add files via upload * Add Uniswap4 to module exports * Delete uniswap/uniswap-v4 directory * Add files via upload * Refactor uniswap4.py by removing unused imports Removed unused imports and cleaned up code formatting. * Add files via upload Pool manager contract ABI * Delete uniswap/configs/evmuniV4_permit2.ini Deleted due to naming fix * Delete uniswap/configs/evmuniV4_chains.ini Deleted due to naming fix * Delete uniswap/configs/evmuniV4_quoter.ini Deleted due to naming fix * Delete uniswap/configs/evmuniV4_router.ini Deleted due to naming fix * Delete uniswap/configs/evmuniV4_stateview.ini Deleted due to naming fix * Add files via upload Naming fix * Add files via upload Liquidity pools list management class added, UniswapV4 improvements. * Delete uniswap/uni4base.py refactor * Delete uniswap/configs/chains.ini refactor * Delete uniswap/configs directory refactor * Beta refactoring+bug fixes * Add files via upload * Add files via upload * Delete uniswap/v4pools.py moved to util * Delete uniswap/v4types.py moved to types * Delete uniswap/v4constants.py moved to constants * Add files via upload Structure refactoring; fixes; StateView contract support added * Formmating fixes, naming fixes * fix constants * Fix util * technical commit * Technical fixes * pre-commit formatter/linter * fix pyproject.toml * ci: update GitHub Actions to supported versions * ci: fix python version output quoting in workflow * build(deps): update poetry.lock * typecheck fixes * review fixes * poetry.lock update * more typecheck fixes * more typecheck * get_token fix * PositionDescriptor support; PositionManager read methods support; misc * fixes * PositionManager full support; PoolManager full support; contracts-related methods naming improvement. * fixes * review fixes * extra fix * poetry.lock fix * v4 test prototype * Update uniswap/uniswap4.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update tests/v4tests.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix * tech commit * tech fix * fix(ci): replace rate-limited Infura with public RPC (#431) * fix(ci): replace rate-limited Infura with public RPC and fix type errors - Switch PROVIDER_MAINNET fallback from Infura to ethereum.publicnode.com (Infura public key was hitting "Too Many Requests" rate limits) - Add dev/v4 and dev/v4-fin branches to CI triggers - Fix mypy errors: use str() for bytes fallback in token name/symbol decode, add type: ignore for web3 get_logs attribute Co-authored-by: Bob <bob@superuserlabs.org> * fix(ci): switch Arbitrum RPC and resolve mypy warning * fix(ci): stop push runs from preferring stale mainnet secret (#432) * Added multi-hop quotes support * review fixes * Checks improvements, small logic fix, multi-hop tests added * Added multi-hop swaps support; added market pricing functions similar to main class; removed hardcoded zero values regarding hooks; impoved pool data fetching process; misc improvement * review fix * typecheck fix * Improved exceptions handling; get_logs() glitch fix * Added swap tests; added liquidity read functions; added liquidity tests * typo fix * Fixes: get_poolkeys_sublist() - addresses comparison; estimate_price_impact() - route param removed; decode_position_info() - imcorrect input value handling * Fix: decode_position_info() - truncated poolID decoding * Add get_position_value() and get_minted_token_id(); related tests; tick math improved; misc * get_amounts_for_liquidity_by_ticks() refactoring; review suggestions added * typecheck glitch fix * typo * typo * get_sqrt_ratio_at_tick() moved to util.py as it is shared with v3; get_minted_token_id() refactoring to support multiple mints * review suggestion * review suggestion * Add liquidity management methods; add router commands and pool actions constants * quick self-fix * typos * typos * Changed direct contract call methods naming to improve usability * typo * Improve log processing in fetch_poolkey_data(); typos fixed * Add fetch_poolkey_data() reconnect functionality * Change fetch_poolkey_data(): param/var renamed and docstring changed for better clarity; tests exceptions handling improved slightly. * Add universal router prerequisites * quick fix * Add universal router support * Review fixes * review suggestions * Review suggestions * Review suggestions * Fixed custom recipient' logic in swaps; fixed ABIs constants. * review fixes * Removed custom recipent in swaps; tests added. * quick fix * misc fixes * Switch from ganachr to foundry-anvil for v4 tests * fix * fix * fix * fix * fix * fix * fix * fix * fix * Add custom transactions' nonce; custom delay time within approve(); universal router' commands and actions ABIs clarified * fix * ABI fix * fix * Add more v4 tests * fix * fix * fix * fix * fix * fix * fix * Add more tests * fix * Add liquidity tests * fix * Add swap tests * fix * fix * fix * fix * Add fetch pool data test * Add the rest of pool data tests * Add liquidity postions management tests. * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * Add StateView and PositionDescriptor tests; liquidity tests reorg. * fix * fix * fix * fix * Add Universal_router_execute() tests * fix * fix * Add positive slippage collection * Fix comments * Fix positive slippage recipient * Minor fixes. * Fix * RC * fix * Docstrings clarification, comments on universal_router_execute() usage * fix * Fix position_manager_permit2_single() * Fix constructor network handling * fix * Docstrings clarification * fix * Add testnets, minor constructor improvements * Docstrings clarification * Add router v2.1.1 support; add X Layer, Tempo, Robinhood networks support; removes Blast and testnets support. * fix * abi fix for multihop swap * fix * fix * tests fix * fix singlehop swaps abi, method and tests * unversal router execute() test fix * Add ReservesLens support * draft fixes * getPoolTVLBatch fix * getPoolTVLBatch params refactoring * docstring clarification * Fix ruff versions clownshow; docstring clarificatiom --------- Co-authored-by: Erik Bjäreholt <erik@bjareho.lt> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Bob <bob@superuserlabs.org>

TimeToBuildBob mentioned this pull request Mar 26, 2026

Fixing CI #430

Closed

fix(ci): switch Arbitrum RPC and resolve mypy warning

06fa436

ErikBjare merged commit b2eb3a0 into uniswap-python:dev/v4-fin Mar 26, 2026
4 of 5 checks passed

TimeToBuildBob mentioned this pull request Mar 26, 2026

fix(ci): stop push runs from preferring stale mainnet secret #432

Merged

Navigation Menu

fix(ci): replace rate-limited Infura with public RPC - #431

fix(ci): replace rate-limited Infura with public RPC#431
ErikBjare merged 2 commits into
uniswap-python:dev/v4-finfrom
TimeToBuildBob:fix/ci-public-rpc

TimeToBuildBob commented Mar 26, 2026

Uh oh!

greptile-apps Bot commented Mar 26, 2026

Uh oh!

TimeToBuildBob commented Mar 26, 2026

Uh oh!

codecov Bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

TimeToBuildBob commented Mar 26, 2026

Uh oh!

Uh oh!

TimeToBuildBob commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

TimeToBuildBob commented Mar 26, 2026

Summary

Context

Test plan

Uh oh!

greptile-apps Bot commented Mar 26, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

TimeToBuildBob commented Mar 26, 2026

Uh oh!

codecov Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

TimeToBuildBob commented Mar 26, 2026

Uh oh!

Uh oh!

TimeToBuildBob commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Mar 26, 2026 •

edited

Loading