Skip to content

feat: price impact excludes fees #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 4 commits into from
Sep 8, 2023
Merged

feat: price impact excludes fees #325

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1b1083
feat: added util functions for fee calculations
Voyz Mar 18, 2023
d88362d
feat: price impact calculation now excludes fees
Voyz Mar 18, 2023
99cef12
removed unused 'fraction_to_fee' and reformatted with black
Voyz Jul 21, 2023
644e71f
Merge branch 'master' into master
Voyz Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into master
  • Loading branch information
@Voyz
Voyz authored Jul 21, 2023
commit 644e71ff67cfaf6417a25a7adbc21aba27276af3
7 changes: 6 additions & 1 deletion tests/test_uniswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,11 @@ def test_assets(client: Uniswap):
"""
tokens = get_tokens(client.netname)

for token_name, amount in [("DAI", 100 * 10**18), ("USDC", 100 * 10**6)]:

for token_name, amount in [
("DAI", 10_000 * ONE_DAI),
("USDC", 10_000 * ONE_USDC),
]:
token_addr = tokens[token_name]
price = client.get_price_output(_str_to_addr(ETH_ADDRESS), token_addr, amount)
logger.info(f"Cost of {amount} {token_name}: {price}")
Expand Down Expand Up @@ -130,6 +134,7 @@ def does_not_raise():
yield



ONE_ETH = 10**18
ONE_USDC = 10**6

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.