Skip to content

ICU-21081 Make U_ASSERT C++14 compatible - #1132

Merged
jefgen merged 1 commit into
masterfrom
sffc-patch-1
May 9, 2020
Merged

jefgen merged 1 commit into
masterfrom
sffc-patch-1

Conversation

@sffc

@sffc sffc commented Apr 25, 2020 •

Copy link
Copy Markdown
Member

@jefgen How/where would you recommend adding a C++14 build bot?

Checklist

@sffc
sffc requested review from jefgen and roubert April 25, 2020 00:24
@jefgen

jefgen commented Apr 27, 2020 •

Copy link
Copy Markdown
Member

How/where would you recommend adding a C++14 build bot?

Hmm, I think we could likely add another build bot for it -- though we should probably also update to Ubuntu 18.04 as well for it. Let me see...

@jefgen jefgen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jefgen
jefgen merged commit 715d254 into master May 9, 2020
@sffc
sffc deleted the sffc-patch-1 branch May 12, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants