Skip to content

Add the parent expect to the prototype chain of a child expect #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
papandreou merged 3 commits into from
Apr 26, 2022
Merged

Add the parent expect to the prototype chain of a child expect #785

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ebf2e0
Make a child expect's prototype chain include the parent expect
papandreou Dec 23, 2020
0ad1bb0
Hmm, why shouldn't child expects made before installing a hook be aff…
papandreou Dec 23, 2020
16e4b28
Prevent test from bleeding into the global expect
papandreou Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Hmm, why shouldn't child expects made before installing a hook be aff… 
…ected, really?

(cherry picked from commit 0217052)
  • Loading branch information
@papandreou
papandreou committed Apr 25, 2022
commit 0ad1bb05136f5cd0e1fbaa20e0b466a780841e15
4 changes: 2 additions & 2 deletions test/api/hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe('hook', () => {
});

describe('with expect.child', () => {
it('should not affect child instances made before installing the hook', () => {
it('should affect child instances made before installing the hook', () => {
const parentExpect = expect.clone();
const childExpect = parentExpect.child();

Expand All @@ -59,7 +59,7 @@ describe('hook', () => {
});

childExpect(123, 'to equal', 123);
expect(called, 'to be false');
expect(called, 'to be true');
});

it('should not affect child instances made after installing the hook', () => {
Expand Down