Skip to content

Add "to have properties satisfying" and deprecate value in "to have property" #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexjeffburke wants to merge 4 commits into from
Closed

Add "to have properties satisfying" and deprecate value in "to have property" #687

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd33168
Implement "to have properties satisfying" assertion.
alexjeffburke Jan 4, 2020
6c74a8a
Adapt tests in light of review feedback.
alexjeffburke Jan 5, 2020
248f6f5
Add a utility method for creating deprecation warnings.
alexjeffburke Jan 5, 2020
cfec63a
Output deprecation notice for "to have property" with value argument.
alexjeffburke Jan 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a utility method for creating deprecation warnings. 
Arrange for this to contain the logic for showing once. Do a little
extra work to make sure the warning is coloured on the console.
  • Loading branch information
@alexjeffburke
alexjeffburke committed Jan 5, 2020
commit 248f6f5c77d2be14be791f931a83737bd900a319
24 changes: 24 additions & 0 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
const canSetPrototype =
Object.setPrototypeOf || { __proto__: [] } instanceof Array;
const greedyIntervalPacker = require('greedy-interval-packer');
const magicpen = require('magicpen');

const setPrototypeOf =
Object.setPrototypeOf ||
Expand Down Expand Up @@ -375,5 +376,28 @@ const utils = (module.exports = {
} else if (typeof process === 'object' && process.env) {
return process.env[varName];
}
},

createDeprecationWarning(message) {
let deprecationWarningDisplayed = false;

return () => {
if (deprecationWarningDisplayed) {
return;
}

deprecationWarningDisplayed = true;

let format = magicpen.defaultFormat;
if (format === 'html') {
// override given this will be output in the browser console
format = 'text';
}
console.warn(
magicpen()
.text(message, 'bgYellow', 'black')
.toString(format)
);
};
}
});