Conversation
The example in section 6 (Simple Data Extraction - LLM-based) uses BrowserConfig, CacheMode, and Dict without importing them, causing the snippet to fail with NameError when run as documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LLM-based extraction example in section 6 of
docs/md_v2/core/quickstart.mdusesBrowserConfig,CacheMode, andDictwithout importing them, so running it as documented fails withNameError: name 'Dict' is not defined(and would then fail again onBrowserConfig).Verified by extracting the exact snippet and running it: it raises
NameErrorbefore the fix and runs past that point after addingfrom typing import Dictand importingBrowserConfig/CacheModefromcrawl4ai.This is the same class of issue already fixed in section 4 by #1715; section 6 was missed.