chore: migrate to new versions of prosemirror packages by bdbch · Pull Request #2854 · ueberdosis/tiptap

bdbch · 2022-06-07T00:29:01Z

Since Prosemirror switched to Typescript in their new version Tiptap was broken on a fresh install because of a non-fixed version requiring a workaround via overrides. See this issue: #2836

In this PR I'm working on a fix for that to migrate to the new prosemirror versions by default.

netlify · 2022-06-07T00:29:07Z

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	`75740d3`
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/62b04011aa8c740392b7cf99
😎 Deploy Preview	https://deploy-preview-2854--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bdbch · 2022-06-07T01:16:22Z

Because of this upgrade, the tables package is broken for now.
See: ProseMirror/prosemirror-tables#96

I'll see if I can find a fix - otherwise will revert the tables package back to a version that still works.

anton-liubushkin · 2022-06-20T11:57:18Z

🔥

enriquecastl · 2022-06-21T14:24:25Z

-    "prosemirror-model": "^1.16.1",
-    "prosemirror-state": "^1.3.4",
-    "prosemirror-view": "^1.23.6"
+    "lowlight": "^1.20.0",


Hi @bdbch!

I’m trying to upgrade tiptap packages in our application, and I noticed that in the latest released version of code-block-lowlight declares the lowlight package as a dependency and a peerDependency: https://unpkg.com/browse/@tiptap/extension-code-block-lowlight@2.0.0-beta.72/package.json

This is not the case in the master branch: https://github.com/ueberdosis/tiptap/blob/main/packages/extension-code-block-lowlight/package.json#L25.

What I find confusing is that part of the changes that I submitted in the PR that moves lowlight to a peerDependency are also included in the latest released version, which differs from what exists in the master branch.

Why is the package.json file different in the master branch and the released package?

Thats weird, could you bring this up in an issue so we can track it? I'd like to look into where this dependency is coming from.

Thanks for the quick response @bdbch 🙇🏼. I created the issue: #2915

rootlinux2 · 2022-06-22T02:37:19Z

Any advance here?

iamursky · 2022-06-22T16:33:22Z

Any advance here?

Upgrade your dependencies.

bdbch · 2022-06-22T20:53:35Z

This is already merged @rootlinux2 the problem you described is coming from the prosemirror-tables package. I'll fork it and work on it to make it work with cjs / require syntax.

rootlinux2 · 2022-06-22T23:47:22Z

@bdbch, @Amursky
I updated tip-tap to the latest versions

but I'm still facing this error!

Error: Must use import to load ES Module: /home/rootlinux2/Documents/Front10/apexedge-widgets/node_modules/prosemirror-tables-contently/dist/index.js
require() of ES modules is not supported.
require() of /home/rootlinux2/Documents/Front10/apexedge-widgets/node_modules/prosemirror-tables-contently/dist/index.js from /home/rootlinux2/Documents/Front10/apexedge-widgets/node_modules/@tiptap/extension-table/dist/tiptap-extension-table.cjs.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /home/rootlinux2/Documents/Front10/apexedge-widgets/node_modules/prosemirror-tables-contently/package.json.

bdbch · 2022-06-24T08:24:55Z

Hey @rootlinux2 we'll publish a new release ASAP. I'll let you know.

* refactor: upgrade prosemirror packages to new typescript versions * refactor: migrate to new typings from prosemirror * style: fix linting issues * style: fix linting issues * style: fix linting issues * fix(ci): fix build process by reimplement filterTransaction * fix(extension-test): fix broken build because of wrong output file names * fix: fix prosemirror-tables not being bundled correctly for ES6 * fix: move to prosemirror-tables-contently until es6 build is working * fix: fix tests for youtube * fix: fix youtube test * fix(demos): fix demos build

bdbch added 3 commits June 6, 2022 20:01

refactor: upgrade prosemirror packages to new typescript versions

1307423

refactor: merge main into prosemirror-ts-update

8149746

refactor: migrate to new typings from prosemirror

bc1e7e8

bdbch added 2 commits June 7, 2022 02:34

style: fix linting issues

95b8850

style: fix linting issues

2ecedb6

bdbch added 2 commits June 17, 2022 20:42

refactor: merge main into branch & resolve conflicts

e9e8c86

style: fix linting issues

177d0eb

bdbch marked this pull request as ready for review June 17, 2022 19:24

anton-liubushkin mentioned this pull request Jun 18, 2022

Cell selection errors #521

Closed

bdbch added 7 commits June 18, 2022 12:17

fix(ci): fix build process by reimplement filterTransaction

9d4d309

fix(extension-test): fix broken build because of wrong output file names

63146e4

fix: fix prosemirror-tables not being bundled correctly for ES6

5301636

fix: move to prosemirror-tables-contently until es6 build is working

6eb2855

fix: fix tests for youtube

b711aff

fix: fix youtube test

7e6a20e

fix(demos): fix demos build

75740d3

bdbch changed the title ~~WIP: chore: migrate to new versions of prosemirror packages~~ chore: migrate to new versions of prosemirror packages Jun 20, 2022

bdbch merged commit 1ebc8f8 into main Jun 20, 2022

bdbch deleted the prosemirror-ts-update branch June 20, 2022 09:45

andy1li mentioned this pull request Jun 21, 2022

TextSelection warning from prosemirror-state 1.4.0 #2846

Closed

1 of 2 tasks

enriquecastl reviewed Jun 21, 2022

View reviewed changes

rootlinux2 mentioned this pull request Jun 22, 2022

Error: Must use import to load ES Module - @tiptap/extension-table #2905

Closed

1 of 2 tasks

kivikakk mentioned this pull request Aug 16, 2022

isTextSelection always returns false #2979

Closed

2 tasks done

coderabbitai Bot mentioned this pull request Sep 12, 2026

fix: allow selecting tables alongside other blocks TypeCellOS/BlockNote#3085

Open

Navigation Menu

Uh oh!

chore: migrate to new versions of prosemirror packages - #2854

chore: migrate to new versions of prosemirror packages#2854
bdbch merged 14 commits into
mainfrom
prosemirror-ts-update

bdbch commented Jun 7, 2022

Uh oh!

netlify Bot commented Jun 7, 2022 •

edited

Loading

Uh oh!

bdbch commented Jun 7, 2022

Uh oh!

anton-liubushkin commented Jun 20, 2022

Uh oh!

enriquecastl Jun 21, 2022

Uh oh!

bdbch Jun 21, 2022

Uh oh!

enriquecastl Jun 22, 2022

Uh oh!

rootlinux2 commented Jun 22, 2022

Uh oh!

iamursky commented Jun 22, 2022

Uh oh!

bdbch commented Jun 22, 2022

Uh oh!

rootlinux2 commented Jun 22, 2022

Uh oh!

bdbch commented Jun 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

bdbch commented Jun 7, 2022

Uh oh!

netlify Bot commented Jun 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for tiptap-embed ready!

Uh oh!

bdbch commented Jun 7, 2022

Uh oh!

anton-liubushkin commented Jun 20, 2022

Uh oh!

enriquecastl Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

bdbch Jun 21, 2022

Choose a reason for hiding this comment

Uh oh!

enriquecastl Jun 22, 2022

Choose a reason for hiding this comment

Uh oh!

rootlinux2 commented Jun 22, 2022

Uh oh!

iamursky commented Jun 22, 2022

Uh oh!

bdbch commented Jun 22, 2022

Uh oh!

rootlinux2 commented Jun 22, 2022

Uh oh!

bdbch commented Jun 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify Bot commented Jun 7, 2022 •

edited

Loading