Skip to content

Implement some missing features for Presto #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nooberfsh wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Implement some missing features for Presto #67

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
61b70f4
ignore files generated by intellij idea
nooberfsh Nov 30, 2021
4714584
support parenthesized relation
nooberfsh Dec 8, 2021
c81fd0e
Merge pull request #1 from nooberfsh/fix
nooberfsh Jan 19, 2022
9d8ac5d
support SET ROLE/SESSION/TIMEZONE statement in presto
nooberfsh Dec 22, 2021
adc68b8
support named window in presto
nooberfsh Dec 28, 2021
486b28e
ast support lambda expression
nooberfsh Dec 28, 2021
2c700db
support lambda expression in presto
nooberfsh Dec 29, 2021
309cb44
add more tests
nooberfsh Dec 29, 2021
a668332
support lambda in eval
nooberfsh Dec 30, 2021
951ab06
support create table as statement in presto
nooberfsh Jan 2, 2022
5a4d65f
support empty array expression in presto
nooberfsh Jan 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
support SET ROLE/SESSION/TIMEZONE statement in presto
  • Loading branch information
@nooberfsh
nooberfsh committed Jan 19, 2022
commit 9d8ac5dc1ead5a3ddce82508ad487c30e21a1063
10 changes: 10 additions & 0 deletions dialects/presto/src/Database/Sql/Presto/Parser.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ statementParser = do
, PrestoUnhandledStatement <$> showP
, PrestoUnhandledStatement <$> callP
, PrestoUnhandledStatement <$> describeP
, PrestoUnhandledStatement <$> setP
]
case maybeStmt of
Just stmt -> terminator >> return stmt
Expand Down Expand Up @@ -1558,3 +1559,12 @@ describeP = do
s <- Tok.describeP
e <- P.many1 Tok.notSemicolonP
return $ s <> last e

setP :: Parser Range
setP = do
s <- Tok.setP
_ <- choice [Tok.roleP, Tok.sessionP, Tok.timezoneP]
ts <- P.many Tok.notSemicolonP
pure $ case reverse ts of
[] -> s
e:_ -> s <> e
9 changes: 9 additions & 0 deletions dialects/presto/src/Database/Sql/Presto/Parser/Token.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,3 +635,12 @@ whereP = keywordP "where"

withP :: Parser Range
withP = keywordP "with"

setP :: Parser Range
setP = keywordP "set"

roleP :: Parser Range
roleP = keywordP "role"

sessionP :: Parser Range
sessionP = keywordP "session"
11 changes: 11 additions & 0 deletions test/Database/Sql/Presto/Parser/Test.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,17 @@ testParser = test
, "SELECT a,b FROM (foo CROSS JOIN bar);"
, "SELECT a,b FROM (foo CROSS JOIN bar) a;"
, "SELECT a,b FROM (foo CROSS JOIN bar) a (a,b);"

-- test set statement
, "SET ROLE NONE;"
, "SET SESSION optimize_hash_generation = true;"
, "SET SESSION data.optimize_locality_enabled = false;"
, "SET TIME ZONE LOCAL;"
, "SET TIME ZONE '-08:00';"
, "SET TIME ZONE INTERVAL '10' HOUR;"
, "SET TIME ZONE INTERVAL -'08:00' HOUR TO MINUTE;"
, "SET TIME ZONE 'America/Los_Angeles';"
, "SET TIME ZONE concat_ws('/', 'America', 'Los_Angeles');"
]

, "Exclude some broken examples" ~: map (TestCase . parsesUnsuccessfully)
Expand Down