Reject a Host header with a path, a query or a fragment - #1949
Merged
Merged
Conversation
nigrosimone
marked this pull request as ready for review
October 2, 2026 06:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Http11Probe COMP-HOST-WITH-PATH sends
Host: localhost:8080/pathand gets 200. RFC 9112 3.2 says a Host with an invalid value MUST get a 400, and an authority ends at the first/,?or#(RFC 3986 3.2).The fix adds these three characters to isInvalidHost. gcc compiles the check to one bit test, so the loop does not get longer.
The new test in tests/HttpParser.cpp sends the three hosts, it fails without the fix.
With Http11Probe locally only COMP-HOST-WITH-PATH moves, from Fail to Pass.