Add missing return in TemplatedApp move assignment operator - #1946
Open
Dev-next-gen wants to merge 1 commit into
Open
Dev-next-gen wants to merge 1 commit into
Dev-next-gen wants to merge 1 commit into
Conversation
The move assignment operator added in uNetworking#1914 is declared to return TemplatedApp& but has no return statement. Flowing off the end of a non-void function is undefined behavior (C++ [stmt.return]). Add the missing `return *this;`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TemplatedApp::operator=(TemplatedApp&&), added in #1914, is declared to returnTemplatedApp&but has noreturnstatement. Flowing off the end of a non-void function is undefined behavior per the C++ standard ([stmt.return]). In practice, if the return value is ever used (e.g. chained assignmenta = b = std::move(c)), the caller reads garbage from the stack or a register.I spotted this while compiling with
-Werror=return-type:The fix adds the missing
return *this;.Found by a defect-hunting pipeline I build and run (Dev-next-gen), using Claude Code with Anthropic's Claude Opus 5.