feat(caldav): RRULE-aware time-range matching and CALDAV:expand/limit for REPORT - #21
Merged
Merged
Conversation
… for REPORT Recurring components now match calendar-query time-ranges through their generated instances (RFC 4791 §9.9.1): parseRRULEBlock/parseRRULEValue support FREQ=DAILY|WEEKLY|MONTHLY|YEARLY; INTERVAL; COUNT; UNTIL, and rruleInstances generates instances with a bounded iteration cap — compFilterMatches matches when ANY instance intersects the range. Unsupported RRULE parts degrade the event to base-only matching (documented subset). CALDAV:expand/limit are parsed from their RFC 4791 §9.6 location inside DAV:prop: expand replaces the response calendar-data with RECURRENCE-ID'd VEVENT instances within the expand window (non-recurring events pass through when their base time is inside); limit/nresults caps the instances. Regression: internal/caldav/calendarquery_rrule_expand_test.go — red before the feature (the recurring event was invisible to a Mar 5 time-range REPORT; 0 RECURRENCE-ID instances), green after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements the recorded CalDAV REPORT features (the round-55 design list):
component matches when ANY generated instance intersects the range —
the base DTSTART alone is no longer decisive. Supported subset:
FREQ=DAILY|WEEKLY|MONTHLY|YEARLY; INTERVAL; COUNT; UNTIL. Unsupported
parts (BYDAY, BYMONTH, ...) degrade the event to base-only matching
(documented).
RECURRENCE-ID'd VEVENT instances within the expand window (parsed from
its RFC location inside DAV:prop).
before.
Verification
Mar 5 time-range REPORT; the expand request returned 0 RECURRENCE-ID
instances. GREEN after: all three new tests pass.
go vet ./internal/caldav/clean; caldav package ok; full suitego test ./...exit 0 / 37 ok (r71-suite.log).