Repository navigation
Whale peek size, keep pets on screen, and the more-pets announcement - #137
Merged
Merged
Conversation
The edge-peek art is drawn about 1.8 times larger than the sprite frames but was always painted 170 canvas pixels tall, so her head nearly doubled when she docked. It now uses the frame scale divided by that ratio. Releasing a pet over the screen edge without reaching the dock range (about a quarter of the window past the edge) left the window half off screen and cut off the session card above it. Releasing now pulls an undocked window back inside the work area on Windows and macOS.
Users who already answered the virtual office invitation get a one-time dialog: "增加更多宠物，丰富您快乐工作的每一天" with Clippy, Rover and Whale Girl shown as picture and name only. Picking one switches to it and turns desktop pets on; "知道了" closes it. office.json gains pets_promo_seen, claimed atomically through aceDesktop_claimPetsPromo. First-time users consume it together with the invitation (or when they toggle pets before ever seeing it), so nobody gets two dialogs. The dialog shares the invitation's blocking and guided-tour rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么
keep_desktop_pet_in_work_area，Windows / macOS 同一个纯函数，所有宠物都适用）。office.json新增pets_promo_seen，由aceDesktop_claimPetsPromo原子认领；新用户认领开启邀请时一并消耗，不会连弹两个窗。验证
test-classic-desktop-pets.mjs全过，新增偷看高度断言（80–100 像素）。desktop_pet.cpp语法检查编译通过。test-virtual-office-preferences.mjs（含宣传弹窗：浅色 / 深色 / 窄屏、点选切换、只认领一次）、pnpm build、分层与所有权检查通过。