Repository navigation
Split macOS desktop pet helpers to fix layer-lint size limit - #134
Merged
Merged
Conversation
desktop_pet_mac.mm grew past the 1000-line R12 limit with the companion-pet work, failing layer-lint on master. Move the WebView bridge shim, environment/locale helpers, scale preference IO, coordinate conversion and resize cursor into desktop_pet_mac_support.hpp (included only by the .mm); no behaviour change. The browser tests now read the shim from the new header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
layer-lint (strict)on master after #132:desktop_pet_mac.mmwas 1068 lines (R12 limit 1000). Helpers and the bridge shim move unchanged intodesktop_pet_mac_support.hpp(923 + 172 lines). All seven layer-lint checks pass locally;test-classic-desktop-pets.mjsandtest-desktop-office.mjspass in macOS-bridge mode. The macOS host is not compiled locally.