Skip to content

Add modules/oxide/tasks/ to dev archive in 7.x - #10532

Open
kkuegler wants to merge 1 commit into
tinymce:release/7from
kkuegler:hotfix/github-10531
Open

Add modules/oxide/tasks/ to dev archive in 7.x#10532
kkuegler wants to merge 1 commit into
tinymce:release/7from
kkuegler:hotfix/github-10531

Conversation

@kkuegler

@kkuegler kkuegler commented Aug 10, 2025

Copy link
Copy Markdown
Contributor

Related Ticket:

Description of Changes:
Including the files in modules/oxide/tasks in tinymce_7.*_dev.zip for it to build cleanly.

Pre-checks:

  • Changelog entry added
  • Tests have been added (if applicable)
  • Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
  • Docs ticket created (if applicable)

GitHub issues (if applicable): #10531

@kkuegler
Add modules/oxide/tasks/ to dev archive
36aa486 
The files in modules/oxide/tasks need to be included in
tinymce_7.*_dev.zip for it to build cleanly.

fixes tinymce#10531
@kkuegler
kkuegler requested a review from a team as a code owner August 10, 2025 11:31
@coderabbitai

coderabbitai Bot commented Aug 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@TheSpyder

TheSpyder commented Aug 13, 2025

Copy link
Copy Markdown
Member

Ah, an oversight when we switched from gulp to grunt in oxide. Have you checked that the resulting dev zip compiles as you expect?

@kkuegler

kkuegler commented Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

Yes, with these files it compiles cleanly.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spocke spocke Awaiting requested review from spocke spocke is a code owner automatically assigned from tinymce/tinymce-reviewers
@TheSpyder TheSpyder Awaiting requested review from TheSpyder TheSpyder is a code owner automatically assigned from tinymce/tinymce-reviewers
@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Community PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kkuegler @TheSpyder