Skip to content

[Carver] Remove unreachable tensor-core shared-scope branches - #3358

Open
dajiaohuang wants to merge 1 commit into
tile-ai:mainfrom
dajiaohuang:cleanup/tensorcore-shared-scope
Open

[Carver] Remove unreachable tensor-core shared-scope branches#3358
dajiaohuang wants to merge 1 commit into
tile-ai:mainfrom
dajiaohuang:cleanup/tensorcore-shared-scope

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Oct 1, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Summary

TensorCorePolicy._assign_block_size assigns shared.dyn unconditionally after the float32 and shared-memory-capacity branches. Those earlier assignments are therefore unreachable as effective settings. Remove the redundant branches and keep one explicit assignment; generated configuration remains unchanged.

Related issue: #3164.

Validation

  • ruff check tilelang/carver/roller/policy/tensorcore.py
  • ruff format --check tilelang/carver/roller/policy/tensorcore.py
  • Python syntax compilation of the edited file
  • git diff --check

Summary

  • Removed redundant conditional assignments to shared.dyn in TensorCorePolicy._assign_block_size.
  • Kept one explicit assignment, preserving the existing dynamic shared-memory scope for tensor-core hints.

Validation

The author reports passing Ruff lint and format checks, Python syntax compilation, and git diff --check. These results were not independently verified.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: tile-ai/tilelang/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 477d3f99-25f2-4bb2-94fc-9acb016b1886

📥 Commits

Reviewing files that changed from the base of the PR and between 994b44e and 3383b57.

📒 Files selected for processing (1)
  • tilelang/carver/roller/policy/tensorcore.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The tensor-core policy now assigns shared.dyn for all tensor-core hints. It no longer selects shared-memory scope based on intrinsic output type or shared-memory usage.

Changes

Tensor-core policy

Layer / File(s) Summary
Assign shared-memory scope
tilelang/carver/roller/policy/tensorcore.py		 The unconditional shared.dyn assignment now sets the scope for all tensor-core hints.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor

Suggested reviewers: mocusez

Merge Risk: ⚪ Minimal · up to 3383b

This cleanup removes redundant assignments in the tensor-core policy and is not expected to change generated configurations. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing unreachable tensor-core shared-scope branches in Carver.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dajiaohuang