Repository navigation
fix: correct Windows runtime dependency auditing - #40
Merged
brianheineman merged 3 commits intoOct 7, 2026
Merged
brianheineman merged 3 commits into
brianheineman merged 3 commits into
Conversation
brianheineman
force-pushed
the
fix/windows-runtime-audit
branch
from
October 7, 2026 05:11
883a87e to
4227e74
Compare
Contributor
Author
|
Thanks @brianheineman — agreed that the The review thread is resolved, and all 25 checks on that commit are green, including the native Windows build and the Linux/macOS matrix: https://github.com/theseus-rs/postgresql-binaries/actions/runs/37575099813. Are you happy for us to merge #40 into |
brianheineman
merged commit Oct 7, 2026
39ff95b
into
theseus-rs:fix-runtime-dependencies
25 checks passed
brianheineman
added a commit
that referenced
this pull request
Oct 7, 2026
fix: correct Windows runtime dependency auditing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up targets
fix-runtime-dependenciesto resolve the Windows runtime audit failures in #35.Two issues prevent the Windows package from reaching its archive tests:
_wmi.pydimportspropsys.dll, but the audit does not recognize it as a Windows system library. Addpropsysto the existing allowlist.stackbuilder.exe. Its large LLVM import report exposes apipefailbug:grep -qexits after matching the format header, andprintffails with a broken pipe. Consume the complete report during the format check.Regression tests cover
_wmi's normal and delayed imports and a large LLVM report. Missing DLLs and malformed binaries still fail. The archive smoke test also imports_wmithrough PL/Python on Windows with Python 3.12 or newer, where the module is available.All 25 upstream CI checks pass at
4227e7442153aa3b8c497aace5e0094b7c35c24a, including the regression suite and all 23 Linux, macOS, and Windows build targets.The Windows audit fixes were also validated in a private GitHub Actions copy using native Windows x64, PostgreSQL 18.6, and CPython 3.13.15:
.tar.gzand.ziparchives pass the relocated PostgreSQL, SQL, extension, and PL/Python tests with the runner's Python paths and environment variables removed.The separate Windows-only CI harness used for private validation is not included in this PR. Other PostgreSQL versions have not been rerun for this patch.