Repository navigation
fixing network quota resource - #1316
Merged
ozerovandrei merged 1 commit intoNov 30, 2021
Merged
Conversation
|
Build failed.
|
Member
|
recheck |
|
Build failed.
|
ozerovandrei
approved these changes
Nov 30, 2021
ozerovandrei
left a comment
ozerovandrei
left a comment
Member
There was a problem hiding this comment.
LGTM thank you @n-marton
Contributor
Author
|
awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change is required to make networking_quota_v2 resource to work properly
this problem with the origin solution, is that it doesn't "honor" the omitempty setting of keys in the underlaying lib
.Get() defaults to 0 if there is no key, so even undefined keys were passed to openstack api with 0 value
with the .GetOk() approach it is possible to change each quota individually without affecting any other, as the underlaying lib and the api supports