Skip to content

Enable admin tests and configure rest for non-admin - #1213

Merged
ozerovandrei merged 1 commit into
terraform-provider-openstack:mainfrom
nikParasyr:issue/1211
Apr 2, 2021
Merged

Enable admin tests and configure rest for non-admin#1213
ozerovandrei merged 1 commit into
terraform-provider-openstack:mainfrom
nikParasyr:issue/1211

Conversation

@nikParasyr

@nikParasyr nikParasyr commented Mar 25, 2021

Copy link
Copy Markdown
Member

Add new job to run admin tests.
Add helper function to run only when non-admin user used.
Update all non-admin tests to use new helper function.

For #1211

@theopenlab-ci

theopenlab-ci Bot commented Mar 25, 2021

Copy link
Copy Markdown

Build failed.

@nikParasyr

nikParasyr commented Mar 26, 2021

Copy link
Copy Markdown
Member Author

recheck

@theopenlab-ci

theopenlab-ci Bot commented Mar 26, 2021

Copy link
Copy Markdown

Build failed.

@nikParasyr

nikParasyr commented Mar 26, 2021

Copy link
Copy Markdown
Member Author

Admin scenarios failing:
--- FAIL: TestAccNetworkingV2QoSMinimumBandwidthRuleDataSource_basic (0.07s) (missing required argument)
--- FAIL: TestAccBlockStorageV2Quotaset_importBasic (4.74s)
--- FAIL: TestAccBlockStorageV3Quotaset_importBasic (3.01s)
--- FAIL: TestAccIdentityV3Project_basic: testing.go:705: Step 1 error: Check failed: Check 8/9 error: openstack_identity_project_v3.project_1: Attribute 'tags.1' not found
--- TestAccNetworkingV2Port_portBinding_update: testing.go:705: Step 4 error: Check failed: Check 5/5 error: openstack_networking_port_v2.port_1: Attribute 'binding.0.host_id' expected "", got "localhost"
--- TestAccNetworkingV2Port_qos_policy_update: testing.go:705: Step 1 error: Check failed: Check 3/3 error: openstack_networking_port_v2.port_1: Attribute 'qos_policy_id' expected to be set
--- TestAccNetworkingV2QoSBandwidthLimitRule_basic: testing.go:705: Step 1 error: Check failed: Check 6/6 error: openstack_networking_qos_bandwidth_limit_rule_v2.bw_limit_rule_1: Attribute 'direction' expected "ingress", got "egress"

haven't checked yet if tests are skipped that shouldn't be skipped

@theopenlab-ci

theopenlab-ci Bot commented Mar 26, 2021

Copy link
Copy Markdown

Build failed.

@theopenlab-ci

theopenlab-ci Bot commented Mar 26, 2021

Copy link
Copy Markdown

Build failed.

@theopenlab-ci

theopenlab-ci Bot commented Mar 27, 2021

Copy link
Copy Markdown

Build succeeded.

@nikParasyr
nikParasyr marked this pull request as ready for review March 27, 2021 16:39
@nikParasyr
nikParasyr marked this pull request as draft March 27, 2021 16:52
@nikParasyr
nikParasyr marked this pull request as ready for review March 27, 2021 17:07
@nikParasyr

nikParasyr commented Mar 27, 2021

Copy link
Copy Markdown
Member Author

@ozerovandrei This is ready from my side. Sorry for the size of this one. I made seperate PRs for each test fix to make it a bit cleaner. The previous run had all of the fixes and it passed, now the pipeline should fail.

I took the easiest approach:

  • add the new job
  • create simple check func to see if user is demo
  • add that check to all acc tests that do not require admin

@theopenlab-ci

theopenlab-ci Bot commented Mar 27, 2021

Copy link
Copy Markdown

Build failed.

@nikParasyr
Enable admin tests and configure rest for non-admin
f5e83d5 
Add new job to run admin tests. Add helper function to
run only when non-admin user used. Update all non-admin tests
to use new helper function.
@theopenlab-ci

theopenlab-ci Bot commented Mar 31, 2021

Copy link
Copy Markdown

Build succeeded.

ozerovandrei
ozerovandrei approved these changes Apr 2, 2021
View reviewed changes

@ozerovandrei ozerovandrei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you very much for implementing this @nikParasyr

@ozerovandrei
ozerovandrei merged commit 80b253a into terraform-provider-openstack:main Apr 2, 2021
@nikParasyr
nikParasyr deleted the issue/1211 branch April 7, 2021 10:06
@nikParasyr nikParasyr mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikParasyr @ozerovandrei