Skip to content

docs: Fix FAQ example for not attaching the cluster primary security group - #3726

Merged
bryantbiggs merged 2 commits into
terraform-aws-modules:masterfrom
somaz94:docs/fix-faq-primary-sg-example
Jul 28, 2026
Merged

bryantbiggs merged 2 commits into
terraform-aws-modules:masterfrom
somaz94:docs/fix-faq-primary-sg-example

Conversation

@somaz94

@somaz94 somaz94 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes the FAQ entry I received an error: expect exactly one securityGroup tagged with kubernetes.io/cluster/<CLUSTER_NAME> ....

The entry lists two opposite approaches for resolving the error, but both showed the same example. The second case — "By not attaching the cluster primary security group" — still set attach_cluster_primary_security_group = true, which is the attaching behavior described in the first case. This corrects the second example to attach_cluster_primary_security_group = false so it actually demonstrates not attaching the cluster primary security group (matching the # default is false comment already present).

Closes #3724

Motivation and Context

The contradictory example is confusing for users hitting the expect exactly one securityGroup ... error — the "not attaching" remedy showed code that attaches.

Breaking Changes

None — documentation only.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

Documentation-only change (docs/faq.md); no Terraform code paths are affected.

@somaz94
somaz94 marked this pull request as ready for review June 24, 2026 09:36
@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions Bot added the stale label Jul 25, 2026
@somaz94

somaz94 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Still relevant. This corrects the FAQ example for detaching the cluster primary security group, which currently documents a configuration that doesn't work as written. CI is green and the change is docs-only, so there's no rebase or conflict risk holding it up — it just needs a maintainer look.

@bryantbiggs
bryantbiggs merged commit 7f8acb3 into terraform-aws-modules:master Jul 28, 2026
22 checks passed
@antonbabenko

Copy link
Copy Markdown
Member

This PR is included in version 21.24.1 🎉

@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAQ has same example for two opposite use cases

3 participants