Conversation
certik
force-pushed
the
test_series_generic
branch
from
February 18, 2019 15:57
7a4b561 to
c636917
Compare
Contributor
Author
|
I rebased on top of the latest master. The tests should pass now. |
Member
|
I don't think the test time is a big issue. Were large prec used to test some specific code paths? |
Contributor
Author
That's what I am not sure --- it doesn't seem so. And if it doesn't test anything useful, I would argue the test should be as fast as possible. As we will keep adding more tests in the future, every bit counts. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This speeds up the
test_series_generictest in Debug mode from 1.09s to 0.83s.Before:
After:
This helps with #1012, but still not fixed.