Skip to content

fix(addon): Cloudflare adapter types - #1346

Merged
jycouet merged 15 commits into
sveltejs:mainfrom
sacrosanctic:fix-cloudflare-types
Oct 3, 2026
Merged

jycouet merged 15 commits into
sveltejs:mainfrom
sacrosanctic:fix-cloudflare-types

Conversation

@sacrosanctic

Copy link
Copy Markdown
Contributor

Closes #1345

@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Install the latest version of sv from c58c5bf:

pnx https://pkg.svelte.dev/sv/c/c58c5bfc1a06b4b3b78c9ad0cac8a9fb8ed32e11 create

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1346

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c58c5bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jycouet

jycouet commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

ensureKit3Types(types) passes the array instead of the tsconfig, so data.extends is always undefined and $app/types is never added. No?

@sacrosanctic

Copy link
Copy Markdown
Contributor Author

Omg, I was messing with jj and I lost some changes.

@jycouet
jycouet force-pushed the fix-cloudflare-types branch from 25b7742 to 899a09a Compare October 1, 2026 21:19
@jycouet
jycouet changed the base branch from version-1 to main October 1, 2026 21:19
@jycouet

jycouet commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@sacrosanctic I pushed there and retarget to main. WDYT ?

@sacrosanctic

Copy link
Copy Markdown
Contributor Author

packageManager

It's not working for you? Cause I get a lot of warning about mismatching versions.

This is really out of scope. But while working on this, I feel this logic should not just be in migrate. Image a command similar to eslint, pnpm svelte-kit fix. It's such a simple fix why doesn't the compiler just do it. Thoughts?

Everything else looks fine.

@manuel3108
manuel3108 requested a review from jycouet October 3, 2026 08:30
@jycouet

jycouet commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

packageManager

It's not working for you? Cause I get a lot of warning about mismatching versions.

This is really out of scope. But while working on this, I feel this logic should not just be in migrate. Image a command similar to eslint, pnpm svelte-kit fix. It's such a simple fix why doesn't the compiler just do it. Thoughts?

Everything else looks fine.

was fixed by #1375

@jycouet
jycouet merged commit 0a668cb into sveltejs:main Oct 3, 2026
7 of 8 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 3, 2026
@sacrosanctic
sacrosanctic deleted the fix-cloudflare-types branch October 3, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sveltekit-adapter (Cloudflare) overwrites compilerOptions.types without $app/types on Kit 3

2 participants