Skip to content

Fix #610 #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NimaSarajpoor wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix #610 #907

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bf1ae8
Empty commit
NimaSarajpoor Aug 25, 2023
5b79efb
add test function to test precision for identical subsequences
NimaSarajpoor Aug 25, 2023
1eb878d
add new test function for identical subsequences with different scales
NimaSarajpoor Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test function to test precision for identical subsequences
  • Loading branch information
@NimaSarajpoor
NimaSarajpoor committed Aug 25, 2023
commit 5b79efbfe7821f7c3a9c3d9acbe7ef9fee3fb8fd
25 changes: 25 additions & 0 deletions tests/test_precision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,3 +198,28 @@ def test_distance_symmetry_property_in_gpu():
ref = 0.0

npt.assert_almost_equal(comp, ref, decimal=15)


def test_stump_identical_subsequence_self_join_rare_cases_1():
# This test function is designed to capture the errors that migtht be raised
# due the imprecision in the calculation of pearson values in the edge case
# where two subsequences are identical.
m = 3
zone = int(np.ceil(m / 4))

seed_values = [27343, 84451]
for seed in seed_values:
np.random.seed(seed)

identical = np.random.rand(8)
T_A = np.random.rand(20)
T_A[1 : 1 + identical.shape[0]] = identical
T_A[11 : 11 + identical.shape[0]] = identical

ref_mp = naive.stump(T_A, m, exclusion_zone=zone, row_wise=True)
comp_mp = stumpy.stump(T_A, m, ignore_trivial=True)
naive.replace_inf(ref_mp)
naive.replace_inf(comp_mp)
npt.assert_almost_equal(
ref_mp[:, 0], comp_mp[:, 0], decimal=config.STUMPY_TEST_PRECISION
) # ignore indices