Skip to content

Fixed #1111 Add branching logic for sdp #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NimaSarajpoor wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fixed #1111 Add branching logic for sdp #1200

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2221b1
add branching logic to sdp func in core
NimaSarajpoor Aug 25, 2026
5450557
add test function to improve coverage
NimaSarajpoor Aug 25, 2026
61bd5b7
Merge branch 'stumpy-dev:main' into sdp_branching_logic
NimaSarajpoor Sep 5, 2026
d01573d
Use closure to allow user to set the values of some variables
NimaSarajpoor Sep 6, 2026
a3538d1
avoid using hard-coded value
NimaSarajpoor Sep 6, 2026
6a48340
improve docstrings
NimaSarajpoor Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improve docstrings
  • Loading branch information
@NimaSarajpoor
NimaSarajpoor committed Sep 6, 2026
commit 6a48340f03af4c90fd160e3329ee5e34ac4451fb
35 changes: 27 additions & 8 deletions stumpy/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,23 +655,41 @@ def make_sliding_dot_product(boundaries=None, default_func=None):

Parameters
----------
boundaries : nested list
boundaries : nested list, default None
A list of items, where each item is a list of 3 elements:
* index 0: (LB_m, UB_m)
* index 1: (LB_n, UB_n)
* index 2: func
where, fucn is the sdp function for computing

@seanlaw seanlaw Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func not fucn

the sliding dot product of ``Q`` and ``T``, when
m=len(Q) falls into [LB_m, UB_m], and n=len(T) falls
into [LB_n, UB_n].
m=len(Q) falls into range [LB_m, UB_m], and n=len(T)
falls into range [LB_n, UB_n].
When this is None (default), it will automatically be set to
the following value:
[
[
(3, config.STUMPY_NJIT_SDP_Q_LENGTH),
(3, np.inf),
sdp._njit_sliding_dot_product,
]
]

default_func : class 'function'
A callable object for
default_func : class 'function', default None
A callable object that is used for computing
the sliding dot product between a query `Q` and
time series `T`. This is used when len(Q) and len(T)
values do not fall into any boundary provided
in `boundaries`. When None (default), this will
automatically be set to `sdp._pyfftw_sliding_dot_product`
if available. If not, it will be automatically set to
`sdp._sliding_dot_product`.

Returns
-------
output : numpy.ndarray
Sliding dot product between `Q` and `T`.
sliding_dot_product : callable
A callable object that computes the sliding dot product between ``Q``
and ``T`` using different methods based on len(Q) and len(T). It
internally checks the boundary in `boundaries` and choose a function

@seanlaw seanlaw Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"chooseS"

"""
stumpy_default_func = sdp._sliding_dot_product
if sdp.PYFFTW_IS_AVAILABLE: # pragma: no cover
Expand Down Expand Up @@ -712,7 +730,8 @@ def sliding_dot_product(Q, T):
out : numpy.ndarray
Sliding dot product between ``Q`` and ``T``.
"""
m, n = len(Q), len(T)
m = len(Q)
n = len(T)
if m == n:
return np.array([np.dot(Q, T)])

Expand Down
Loading