feat: Enable video with an env var - #847
Merged
Merged
Conversation
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This comment was marked as outdated.
This comment was marked as outdated.
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
|
|
This comment was marked as outdated.
This comment was marked as outdated.
|
ah I see no worries, excited for it
…-------- Original Message --------
On Saturday, 02/21/26 at 22:19 Jacob Schlecht ***@***.***> wrote:
Dadadah left a comment [(stoatchat/for-web#847)](#847 (comment))
I found a bug with this PR where if the env var isn't defined it crashes. I'll be fixing that before EOD
—
Reply to this email directly, [view it on GitHub](#847 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/B2WWMMGILTQV4G4WDT7GPGL4NDKVNAVCNFSM6AAAAACVZRGGTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMZZGU4TONRWGM).
You are receiving this because you commented.Message ID: ***@***.***>
|
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
chrishultin
approved these changes
Feb 25, 2026
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
mihaicm93
approved these changes
Feb 28, 2026
chrishultin
enabled auto-merge (squash)
February 28, 2026 16:23
Signed-off-by: Christopher Hultin <chris.hultin@gmail.com>
Pecacheu
pushed a commit
to Pecacheu/for-web
that referenced
this pull request
Mar 2, 2026
* feat: Enable video and screenshare with an env variable for self host This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * feat: Enable fullscreening video and screen share streams This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Env var works now, camera view is disabled when camera turned off This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Leave fullscreen when a user stops their camera stream This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: run linter This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Access this env var safely as it may not exist This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Only attempt to exit fullscreen if in fullscreen This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> --------- Signed-off-by: Jacob Schlecht <dadadah@echoha.us> Co-authored-by: Christopher Hultin <chrishultin@google.com>
amycatgirl
pushed a commit
to amycatgirl/stoat-frontend
that referenced
this pull request
Mar 17, 2026
* feat: Enable video and screenshare with an env variable for self host This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * feat: Enable fullscreening video and screen share streams This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Env var works now, camera view is disabled when camera turned off This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Leave fullscreen when a user stops their camera stream This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: run linter This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Access this env var safely as it may not exist This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Only attempt to exit fullscreen if in fullscreen This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> --------- Signed-off-by: Jacob Schlecht <dadadah@echoha.us> Co-authored-by: Christopher Hultin <chrishultin@google.com>
Pecacheu
pushed a commit
to Pecacheu/for-web
that referenced
this pull request
Jun 22, 2026
* feat: Enable video and screenshare with an env variable for self host This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * feat: Enable fullscreening video and screen share streams This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Env var works now, camera view is disabled when camera turned off This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Leave fullscreen when a user stops their camera stream This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: run linter This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Access this env var safely as it may not exist This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> * fix: Only attempt to exit fullscreen if in fullscreen This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us> --------- Signed-off-by: Jacob Schlecht <dadadah@echoha.us> Co-authored-by: Christopher Hultin <chrishultin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an environment variable to enable video for self hosted users. The new variable is
VITE_CFG_ENABLE_VIDEOand defaults to off. The variable must be explicitly set to "true" to enable video. The variable has been added to the docker build process.This PR also adds the ability to fullscreen camera and screen share.
Lastly, this PR fixes the user card remaining a camera card after the camera has been muted (turned off).
Closes #845
Allows closing stoatchat/self-hosted#200