Conversation
Provide the maintainer-requested ndarray interface for counting non-NaN values. Honor selected shape, stride and offset using the existing strided implementation, with declarations, examples and regression coverage. Assisted-by: OpenAI Codex
stdlib-bot
added
the
BLAS
Contributor
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
stdlib-bot
added
First-time Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of #14404.
Description
This pull request adds
@stdlib/blas/ext/base/ndarray/gnancount, which counts non-NaN values in a one-dimensional ndarray view by forwarding its shape, data buffer, stride, and offset to the existing strided routine. It includes TypeScript declarations, documentation, REPL help, an example, a benchmark, and behavioral tests for sliced/reversed views, zero stride, empty inputs, and accessor-backed arrays.Related Issues
ndarrayinterface variants for missing modules in@stdlib/blas/ext/base#14404Questions
No.
Other
Validation: 27/27 package assertions; JavaScript, Markdown, TypeScript, package metadata and REPL help lint; runnable example; 18/18 benchmark assertions; TypeScript 4.9.5 verified 14 expected errors and two numeric return types. Local new package coverage reports 100%.
Checklist
AI Assistance
Yes
No
Code generation
Test/benchmark generation
Documentation (including examples)
Research and understanding
Disclosure
The implementation, tests, benchmarks, TypeScript declarations, and documentation were prepared primarily by OpenAI Codex. The contributing-guidelines acknowledgment records Codex's review and application of the guidelines under benatsf's explicit authorization to contribute. It does not claim that benatsf personally read the guide or manually reviewed the code. No manual applicant review is claimed.