Skip to content

chore(ui): backport vm data decouple tests 4.10 - #23213

Open
dvail wants to merge 2 commits into
release-4.10from
dv/backport-vm-data-decouple-tests-4.10
Open

dvail wants to merge 2 commits into
release-4.10from
dv/backport-vm-data-decouple-tests-4.10

Conversation

@dvail

@dvail dvail commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

Backports two commits from 5.0 that decouple UI e2e tests from scanner responses to reduce test flakes.

Note This was a bit more involved than the 4.11 backport, so we should be absolutely sure ui-e2e test runs are green before merging.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI

@openshift-ci

openshift-ci Bot commented Oct 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions Bot added area/ui backport PR to backport changes from master to release branch labels Oct 2, 2026
@dvail
dvail marked this pull request as ready for review October 2, 2026 16:33
@dvail
dvail requested a review from a team as a code owner October 2, 2026 16:33

@vladbologa vladbologa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll merge only if the ui-e2e tests pass.

@rhacs-bot

Copy link
Copy Markdown
Contributor

Images are ready for the commit at 47ad18b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.10-rc.0-5-g47ad18bf36.

@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.47%. Comparing base (e646d42) to head (47ad18b).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-4.10   #23213      +/-   ##
================================================
- Coverage         49.48%   49.47%   -0.01%     
================================================
  Files              2662     2662              
  Lines            201272   201272              
================================================
- Hits              99597    99587      -10     
- Misses            94227    94235       +8     
- Partials           7448     7450       +2     
Flag Coverage Δ
go-unit-tests 49.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui backport PR to backport changes from master to release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants