Conversation
added 6 commits
September 18, 2026 17:21
SerseusWasTaken
requested changes
Oct 1, 2026
| Long: "Create a STACKIT Kubernetes Engine (SCA) application from payload.", | ||
| Args: args.NoArgs, | ||
| Example: examples.Build( | ||
| // TODO: fix examples |
| } | ||
| } | ||
|
|
||
| payload.DisplayName = flags.FlagToStringValue(p, cmd, nameFlag) |
Contributor
There was a problem hiding this comment.
causes nil pointer dereference when no paylaod is set
Comment on lines
+129
to
+137
| payloadValue := flags.FlagToStringPointer(p, cmd, payloadFlag) | ||
| var payload *sca.CreateApplicationPayload | ||
| if payloadValue != nil { | ||
| payload = &sca.CreateApplicationPayload{} | ||
| err := json.Unmarshal([]byte(*payloadValue), payload) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("enconde payload: %w", err) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
docs state default payload is used when none is set - this is not the case
| } | ||
| } | ||
|
|
||
| payload.AdditionalProperties = nil |
Contributor
There was a problem hiding this comment.
Potential nil pointer dereference when no payload is set
Comment on lines
+22
to
+49
| const ( | ||
| environmentIDFlag = "environment-id" | ||
| nameFlag = "name" | ||
| imageFlag = "image" | ||
| publicFlag = "public" | ||
| externalPortFlag = "external-port" | ||
| cpuFlag = "cpu" | ||
| memoryFlag = "memory" | ||
| instancesFlag = "instances" | ||
| minInstancesFlag = "min-instances" | ||
| maxInstancesFlag = "max-instances" | ||
| scaleToZeroFlag = "scale-to-zero" | ||
| envVarsFlag = "environment-vars" | ||
| commandsFlag = "commands" | ||
| argsFlag = "args" | ||
| ) | ||
|
|
||
| const ( | ||
| scalingTypeManual = "manual" | ||
| scalingTypeAuto = "auto" | ||
|
|
||
| defaultPublic = true | ||
| defaultPort = 8080 | ||
| defaultCPU = 1000 | ||
| defaultMemory = 1024 | ||
| defaultInstances = 1 | ||
| defaultContainerName = "container-1" | ||
| ) |
Contributor
There was a problem hiding this comment.
Nitpick: We can use one const () block for this
| @@ -0,0 +1,199 @@ | |||
| package update | |||
| Long: "Update a STACKIT Kubernetes Engine (SCA) application.", | ||
| Args: args.SingleArg(applicationIDArg, nil), | ||
| Example: examples.Build( | ||
| // TODO: fix examples |
Comment on lines
+175
to
+176
| Concurrency: &model.Concurrency, | ||
| Rps: &model.RPS, |
Contributor
There was a problem hiding this comment.
Looks like concurrency and RPS flags are not wired up - this buildScalingRules function always returns nil
Comment on lines
+242
to
+243
| cmd.Flags().Int32(minInstancesFlag, 0, "The minimum number of application instances (if autoscaling is enabled)") | ||
| cmd.Flags().Int32(maxInstancesFlag, 0, "The maximum number of application instances (if autoscaling is enabled)") |
Contributor
There was a problem hiding this comment.
is 0 for both flags a sensible default value?
Comment on lines
+107
to
+121
| func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel, error) { | ||
| globalFlags := globalflags.Parse(p, cmd) | ||
| if globalFlags.ProjectId == "" { | ||
| return nil, &errors.ProjectIdError{} | ||
| } | ||
|
|
||
| model := inputModel{ | ||
| GlobalFlagModel: globalFlags, | ||
| EnvironmentID: flags.FlagToStringValue(p, cmd, environmentIDFlag), | ||
| Limit: flags.FlagToInt64Pointer(p, cmd, limitFlag), | ||
| } | ||
|
|
||
| p.DebugInputModel(model) | ||
| return &model, nil | ||
| } |
Contributor
There was a problem hiding this comment.
missing validation for limit flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #1234
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)